search

FRBCesab / funbiogeo

:package: R package to help with analyses in functional biogeography
https://frbcesab.github.io/funbiogeo/
GNU General Public License v2.0
10 stars 1 forks source link

Transform site x locations object into 'sf' #20

Closed Rekyt closed 2 years ago

Rekyt commented 2 years ago

This would simplify the environmental extraction process.

codecov-commenter commented 2 years ago

Codecov Report

Merging #20 (e482470) into main (7074534) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          388       367   -21     
=========================================
- Hits           388       367   -21
Impacted Files Coverage Δ
R/checks.R 100.00% <100.00%> (ø)
R/fb_format_sites_locations.R 100.00% <100.00%> (ø)
R/fb_get_environment.R 100.00% <100.00%> (ø)
R/fb_upscale_sites.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7074534...e482470. Read the comment docs.

Rekyt commented 2 years ago

One thing that should be discussed before squash merging this PR is a question I have on how to handle site names.

For the moment the sf object has a site column independently. But we're using row names almost everywhere else. Should we instead create sf objects with row names? I feel it's against the tidyverse style of doing things, and as sf is supported by the tidyverse, we shouldn't use it. But it breaks our consistency.

This will be explored #21 and is not the topic of this PR.