FRBs / sigpyproc3

Python3 version of Ewan Barr's sigpyproc library
https://sigpyproc3.readthedocs.io
MIT License
14 stars 11 forks source link

Multifile #13

Closed pravirkr closed 3 years ago

pravirkr commented 3 years ago

Major API change to support reading contiguous sigproc filterbank files.

Added digitize option to allow digitizing data before writing to file

Cleaned up Utils module. Added a logger function for future use.

pravirkr commented 3 years ago

Thanks, @telegraphic for the review. Merging now.

I will add more tests in another PR. Creating a release v0.5.5 for users to fallback. Changed digitize to quantize. However, keeping the (internal) param names as digi_*, (same as dspsr, to avoid confusion).

Re file format support, I am working on a PR for limited PSRFITS support (with astropy integration). I will open a separate issue to discuss this along with the roadmap ahead.

Yes, I think we should strictly follow PEP8 and in the next release, I aim to have the code fully typed, formatted and linted (following WPS style).