search

FRBs / sigpyproc3

Python3 version of Ewan Barr's sigpyproc library
https://sigpyproc3.readthedocs.io
MIT License
14 stars 11 forks source link

pybind11 update #4

Closed pravirkr closed 4 years ago

pravirkr commented 4 years ago

Moving from ctypes shared libraries to pybind11 C++ bindings. pybind11 is very convenient to use when exchanging data between python and C++ (numpy arrays).

Now, there is no need to search for the shared library (it should load by default). However, we need to add more tests to check if anything is broken.

codecov-io commented 4 years ago

Codecov Report

Merging #4 into master will decrease coverage by 2.32%. The diff coverage is 4.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #4      +/-   ##
==========================================
- Coverage   31.86%   29.54%   -2.33%     
==========================================
  Files          12       12              
  Lines        1114     1117       +3     
==========================================
- Hits          355      330      -25     
- Misses        759      787      +28
Impacted Files Coverage Δ
setup.py 0.00% <0.00%> (ø)
sigpyproc/Filterbank.py 15.38% <5.88%> (+0.05%) :arrow_up:
sigpyproc/FourierSeries.py 26.59% <12.50%> (-1.98%) :arrow_down:
sigpyproc/TimeSeries.py 23.07% <12.50%> (-2.85%) :arrow_down:
sigpyproc/Utils.py 31.42% <33.33%> (-1.91%) :arrow_down:
sigpyproc/ctype_helper.py 0.00% <0.00%> (-100.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1768bbd...e2b9f08. Read the comment docs.