FRC-Sonic-Squirrels / 2023-Robot-Code

2023 FRC Season robot code for team 2930, the Sonic Squirrels
MIT License
8 stars 0 forks source link

make vision subsystem with 2 vision io's for left and right cameras #45

Closed LuminousLlama closed 1 year ago

LuminousLlama commented 1 year ago

you will most likely have to change the code in the VisionIOPhotonVision to accommodate multiple cameras

Also, many of the Vision top-level methods will have to be changed to accommodate polling multiple cameras. Right now it just gets all the data from the 1 io but you might have to add a parameter to each method to check which camera its requesting data from.

also, remember to actually poll both io's in the Vision.java periodic and include its data in the pose estimator

randomstring commented 1 year ago

This can't be closed yet, it hasn't been tested. Not on the robot or in Sim.

Mia, your code looks good, and maybe it works on the robot. However, we can't tell if it works without testing it.

I would really like to confirm that the code is doing the right thing in Sim and then fine tune on the robot. We don't have the time to sit around the practice field to get vision working. We need to get it worked out first in Sim and then in the portable sitting still, and finally driving around in the portable.

It was much too early to merge this into main.

I've been struggling for the last day and a half to get this working in Sim. Even simple things like getting a list of correct id tags visible from a camera is hard. Right now I've got a bug with sim that I think the left camera is really the right and vice versa.