FRC1756-Argos / 2022-Robot

Robot code for 2022 FRC Season
https://frc1756-argos.github.io/2022-Robot/
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Vibration Feedback When Ball At First Sensor #145

Closed dkt01 closed 2 years ago

dkt01 commented 2 years ago

Quick pulse

Litemage commented 2 years ago

Made a new branch that might work with this, did not get a chance to test

Litemage commented 2 years ago

Here is the actual most recent changes: b47027d49a99f6e0232839f04c4c7bf6a4691fdc

dkt01 commented 2 years ago

It looks like this would continuously vibrate while a ball is in front of the ToF sensor. I'm thinking this could be distracting, so we may need a new single pulse vibration model that's triggered on rising edge of cargo detection. Here's an example of how to generate a vibration model to make a timed pulse from another project

dkt01 commented 2 years ago

@Litemage, were there any additional changes you wanted beyond what's in 811bedf?

Litemage commented 2 years ago

Correct me if I'm wrong, but I believe all these changes are not yet tested. So maybe/ maybe not

dkt01 commented 2 years ago

I just tested and it seems to work. I'm good with merging so it's ready to run tomorrow unless you have more you want to try on this.

Litemage commented 2 years ago

@dkt01 Then barring any changes requested by drive, or unforeseen issues, I'm done with it.

dkt01 commented 2 years ago

Merged in ac8036a77fd1e30a1cc1a283dce15f4f2884f7c4