@Litemage Overall, looks great. I made a few (mostly cosmetic) changes. You can see them in d008a687243e65e83a73c9adb64153bcc4df3d36, but the basics are
Renamed network_tables class to NetworkTablesWrapper both to use capital camel case and to reduce similarity to the WPILib network tables class
Moved network_tables.h/cpp out of subsystems subdirectory since that's not actually a subsystem. I'm not sure I like utils, but we can change that
Renamed m_networkTables to m_pNetworkTables to make it clear the type is a pointer
Initialized shared pointer in RobotContainer constructor so we don't crash on first access (hopefully)
@Litemage Overall, looks great. I made a few (mostly cosmetic) changes. You can see them in d008a687243e65e83a73c9adb64153bcc4df3d36, but the basics are
network_tables
class toNetworkTablesWrapper
both to use capital camel case and to reduce similarity to the WPILib network tables classnetwork_tables.h/cpp
out ofsubsystems
subdirectory since that's not actually a subsystem. I'm not sure I likeutils
, but we can change thatm_networkTables
tom_pNetworkTables
to make it clear the type is a pointerRobotContainer
constructor so we don't crash on first access (hopefully)