Closed KyleRAnderson closed 6 years ago
I will remove the debug prints just before merging, don't worry about that.
Having bling code ready is good. We won't have it for Ryerson but we'll install it between competitions.
Nice work!
On 3/13/18, Kyle Anderson notifications@github.com wrote:
Pull request for bling code and the new and improved Rumbler as well as a few small changes to support the Dashboard.
Not sure if we want bling code because of lack of LED strips on the robot but it's there if needed.
Tested on the practice robot to work. You can view, comment on, or merge this pull request online at:
https://github.com/FRC2706/2018-2706-Robot-Code/pull/33
-- Commit Summary --
- Rumbler class created
- Added Bling Subsystem
- BlingPattern added and bling stuff fixed for new api
- Merge remote-tracking branch 'upstream/master'
- Merge remote-tracking branch 'upstream/2018'
- Added debug printing
- Merge remote-tracking branch 'upstream/2018'
- Working bling system
- Merge remote-tracking branch 'upstream/2018'
- Got rid of commented out code and some prints
- Merge remote-tracking branch 'upstream/2018'
-- File Changes --
M src/org/usfirst/frc/team2706/robot/Robot.java (19) D src/org/usfirst/frc/team2706/robot/commands/BatteryReader.java (65) M src/org/usfirst/frc/team2706/robot/commands/IntakeCube.java (4) A src/org/usfirst/frc/team2706/robot/commands/bling/BlingController.java
(138) A src/org/usfirst/frc/team2706/robot/commands/bling/patterns/Blank.java (24) A src/org/usfirst/frc/team2706/robot/commands/bling/patterns/BlingPattern.java (94) A src/org/usfirst/frc/team2706/robot/commands/bling/patterns/IntakeSignaller.java (60) D src/org/usfirst/frc/team2706/robot/controls/StickRumble.java (202) A src/org/usfirst/frc/team2706/robot/controls/operatorFeedback/Rumbler.java (127) A src/org/usfirst/frc/team2706/robot/subsystems/Bling.java (130) M src/org/usfirst/frc/team2706/robot/subsystems/DriveTrain.java (9)
-- Patch Links --
https://github.com/FRC2706/2018-2706-Robot-Code/pull/33.patch https://github.com/FRC2706/2018-2706-Robot-Code/pull/33.diff
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/FRC2706/2018-2706-Robot-Code/pull/33
Yeah, there's no need to merge this before Ryerson. It's actually been ready for a while but I didn't see a point in merging it until after Ryerson when we might get LED strips.
Pull request for bling code and the new and improved Rumbler as well as a few small changes to support the Dashboard.
Not sure if we want bling code because of lack of LED strips on the robot but it's there if needed.
Tested on the practice robot to work.