kevlam2706
commented
5 years ago The days before competition is not the time for "None, minimal changes". Please ensure you test this change on the practice robot before it ends up in our competition code.
On 3/12/19, Kyle Anderson notifications@github.com wrote:
In case the elevator doesn't reach the height it needs to after being too low to deploy a hatch, it was thought to be a good idea to add a timeout on this raise command.
Summary of Changes
- Add timeout of 0.75 seconds in case the lift doesn't raise (gets blocked on something) during hatch eject.
Testing Performed
None, minimal changes.
You can view, comment on, or merge this pull request online at:
https://github.com/FRC2706/2019-2706-Robot-Code/pull/119
-- Commit Summary --
- Add timeout to EjectHatch
-- File Changes --
Msrc/main/java/ca/team2706/frc/robot/commands/intake/hatch/EjectHatch.java (4)
-- Patch Links --
https://github.com/FRC2706/2019-2706-Robot-Code/pull/119.patch https://github.com/FRC2706/2019-2706-Robot-Code/pull/119.diff
-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/FRC2706/2019-2706-Robot-Code/pull/119
KyleRAnderson
In case the elevator doesn't reach the height it needs to after being too low to deploy a hatch, it was thought to be a good idea to add a timeout on this raise command.
Summary of Changes
Testing Performed
Environment: Practice bot (cosmobot) Tried the value and saw the timeout being used in places where the lift didn't rise enough.