search

FRC2706 / 2019-2706-Robot-Code

The main robot code for the FIRST 2019 challenge: Deep Space
MIT License
2 stars 0 forks source link

Implemented FluidConstants for JoystickButtons #28

Closed Zinka010 closed 5 years ago

Zinka010 commented 5 years ago

Summary of Changes

Testing Performed

Deployed and changed used button in NetworkTables Environment: RoboRIO

KyleRAnderson commented 5 years ago

@Zinka010 I guess this includes the stuff that @eandr127 was working on in wpilib-2019? If so we should probably merge #29 first.

KyleRAnderson commented 5 years ago

@Zinka010 I demoed how I thought the FluidConstants should be used in 283831a. I also added a listener to fluid constants so you can run a function when the value changes.

I love the idea of FluidJoystickButton. One thing to consider though is how are you going to update the port for the joystick when the fluid constant changes?

You can merge the branch joystick_fluid-proposal into yours if you want to get the changes.