FRC2706 / 2020-2706-Robot-Code

The Robot Code for the 2020 FIRST Robotics Competition INFINITE RECHARGE
Other
4 stars 2 forks source link

Finished First Iteration of Subsystem Conditions #56

Closed nrgill28 closed 4 years ago

nrgill28 commented 4 years ago

So this is an interesting one. I moved the conditions part of the IntakeSubsystem into it's own set of classes so that all subsystems can benefit from them without having to re-write that code.

To summarize the new system:

For an example of how these work, I've modified the intake subsystem and the operator intake command to use this system.

This is very much a first iteration of the code, it's not perfect but I'd like to put it out there and see what you guys think before I go any further. Aside from the regular code review, I'm also looking for feedback on a couple extra things:

Zinka010 commented 4 years ago

thumbs-up