search

FRC2706 / 2020-2706-Robot-Code

The Robot Code for the 2020 FIRST Robotics Competition INFINITE RECHARGE
Other
4 stars 2 forks source link

Added Agitator Subsystem #90

Closed aadiamazing5 closed 4 years ago

aadiamazing5 commented 4 years ago

Added agitator subsystem, with 3 simple commands. Should eventually be integrated with intake subsystem. Will be bulletproofed soon.

aadiamazing5 commented 4 years ago

@Zinka010 So I've gone through and changed the file on my computer to a singleton pattern (likely won't commit because I'm having trouble getting it to work). I unfortunately won't be able to make it on Friday due to a badminton tournament, but please let me know what tweaks you decide to make to the file so that I can learn and then update my code accordingly. Thanks :)

aadiamazing5 commented 4 years ago

@Zinka010 Would you like me to merge as it is for now or wait until Friday?

kevlam2706 commented 4 years ago

If it isn't working then you shouldn't merge, but maybe Justin can take what you have, make it work, and them commit it into master.

Then you can either pull from master to get it back into your branch, or just close your branch without merging.

On 2/27/20, Aadi Anjaria notifications@github.com wrote:

Would you like to me to merge as it is for now or wait until Friday?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/FRC2706/2020-2706-Robot-Code/pull/90#issuecomment-592076105

aadiamazing5 commented 4 years ago

It works as it is right now on this branch, it just doesn't work on my local device where I was tinkering with Singletons. Merging this branch shouldn't cause any problems. Let me know what you'd like me to do