I made the bling flash purple for five seconds when there is a note l… - Githubissues

FRC2706 / 2024-2706-Robot-Code

Code for the 2024 game.

Other

2 stars 0 forks source link

I made the bling flash purple for five seconds when there is a note l… #108

Closed Patchy-pirate closed 6 months ago

Patchy-pirate commented 6 months ago

…oaded in intake

Describe your changes

[ ] Bug fix
[x] New feature

Explain what you did:

...

Issue ticket (add number)

https://github.com/FRC2706/2024-2706-Robot-Code/issues/...

Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] I have tested thoroughly.
[ ] I have written documentation and explained about my changes to the best of my ability.

Describe your changes
[ ] Bug fix
[X] New feature

Explain what you did:

I made the bling flash purple for five seconds, then change to a solid purple afterwards. When setting bling to a solid colour, if there was any animation playing previously, it wouldn't set to that colour, it would just keep the animation playing. i made it so that setting bling to a solid colour now removes any active animations

Issue ticket (add number)

https://github.com/FRC2706/2024-2706-Robot-Code/issues/...

Checklist before requesting a review

[X] I have performed a self-review of my code.
[X] I have tested thoroughly.
[X] I have written documentation and explained about my changes to the best of my ability.

ErikCald commented 6 months ago

Ideally this should be tested again briefly at Everline, and consider lowering the duration of flashing from 5 seconds to 1 or 2 seconds.