VA intake - Rollers of the Intake

FRC5409 / 2023-Dunkirk

Other

0 stars 0 forks source link

VA intake - Rollers of the Intake #8

Closed AvianSilk closed 1 year ago

AvianSilk commented 2 years ago

An Intake subsystem was created

A command "TakeInTheBall" which takes in the ball

jasonli0616 commented 2 years ago

Intake motor works, just a couple things before merging,

Please put all your numbers in Constants.java! (eg. speed, motor ID, etc). This is so that we can make changes easily when needed (editing one file).
Lower motor speed a bit, 1.0 is max speed which is too bit fast
For your intake ball command, instead of using a 7 sec timer, try binding it to holding down a button instead

jasonli0616 commented 1 year ago

Intake looks pretty good!

Consider having one method that will set left and right solenoids, instead of separate left and right commands? This is just to prevent having the solenoids physically in different states. (also values in Constants.java!)

I see the intake ball command will activate the solenoids and spin the motor; let's test it out on Thursday!

jasonli0616 commented 1 year ago

Also for Thursday when testing out the command: Let's add a button binding to the command; instead of using a timer in the command, bind it to a button.whileHeld(cmd).

AvianSilk commented 1 year ago

Thanks for the feedback ! I’ll (hopefully) work on your suggestions by Thursday

jasonli0616 commented 1 year ago

Notes from our testing today:

Regarding activating solenoids:

See constructor docs

One constructor takes in the pneumatics module ID, and one doesn't. Because our ID isn't the default one, use the constructor that takes in the ID (see link above).

Also, ensure your solenoids forward/reverse are in the right spot in the command!

AvianSilk commented 1 year ago

I made all the changes and pushed it

So it's basically ready to be merged unless I made a mistake

jasonli0616 commented 1 year ago

Also maybe a eject ball command/button binding?