search

FRC5892 / HeroHours

Team 5892's attendance solution
1 stars 4 forks source link

URGENT #31

Closed yyy2356 closed 1 month ago

yyy2356 commented 1 month ago

Change total_hours to a duration field and change all the views and anything that references it to accommodate that.

yyy2356 commented 1 month ago

only you have had your total hours cutoff by this, so we need to fix your time. the total seconds has it backed up, luckily.

yyy2356 commented 1 month ago

I think that maybe only the model needed to be changed, luckily. Everything seems to be working after doing the migration on development.

MichaelStatt-S commented 1 month ago

1 i made a branch for you 2 why don't we just get rid of that all together? We are storing the same value twice. I say just use the total seconds

yyy2356 commented 1 month ago

There was probably some reason... maybe it was just copied over from the original and they needed it for some reason that isn't relevant anymore. Storing it twice might be a good idea anyways for redundancy, and all the infrastructure for it is set up. The change was pretty simple.

yyy2356 commented 1 month ago

my current pr should fix it, less changes needed to be made than i thought as django is pretty resilient.

yyy2356 commented 1 month ago

i overestimated the difficulty, all that needs to happen is fixing your total hours and implementing the changes made in the pr before todays meeting.