search

FRC5892 / HeroHours

Team 5892's attendance solution
1 stars 4 forks source link

Replace Trever #35

Open MichaelStatt-S opened 1 month ago

MichaelStatt-S commented 1 month ago

I don't really like being so dependent on Traver (#13). I think it should only be used for special one-off things that its not worth automating. It shouldn't be too hard to implement what we are doing currently with Trevor

yyy2356 commented 1 month ago

as far as i can tell, the teachers and mentors really like trevor. Why shouldnt we use it?

MichaelStatt-S commented 1 month ago

What feedback have you received for it? To my understanding, they just care about having a sheet. To me, it seems like using trevor is just adding another service that we are barely using that adds a lot of extra complexity (would also make it harder for others to duplicate our program) . Also, if we make our own implementation, we can add extra functionality (lookup by meeting using url parameters).

yyy2356 commented 1 month ago

for other people to copy it, its as simple as exporting the queries and adding them as files. Trevor is a pretty simple system to use. The reason the mentors like Trevor is because its accessible anywhere and it looks good. adding extra functionality is good for sheets, though not fully necessary, but in terms of the dashboard, Trevor does a really solid job. We should discuss at todays meeting and get another opinion.

MichaelStatt-S commented 1 month ago

I'm not saying we need to remove trevor all together, but I would consider the sheets a requirement/ core functionality. All I've done in the pr is make an endpoint for the data, instead of relying on trevor. Trevor is still good for a ui used for occasional queries. I just don't like using it for the 'live user list', 'live activity logs', and each meeting

yyy2356 commented 1 month ago

the primary reason that i like trevor is that it automatically refreshes the data on the sheet hourly. I dont know if thats a unique behavior of trevor, or something built into sheets. if its the former, i would definitely want to keep trevor, if its the latter, im all for switching it out from the sheets and only using it for dashboards

MichaelStatt-S commented 1 month ago

That hourly refresh is built into Google sheets. It just uses a built in formula that downloads a csv of the data. I implemented that in the pr (custom formula for not absolutely garbage auth)