search

FRCDiscord / Dozer

Omnipotent guild management bot for FIRST Discord servers
GNU General Public License v3.0
40 stars 45 forks source link

Updating ftc.py courtesy of @j5155, as well as fixing a past bug with datetime from a previous PR of mine #460

Closed skruglov2023 closed 5 months ago

skruglov2023 commented 8 months ago

Merging changes from https://github.com/ftc-dozer2-0/Dozer2.0/pull/13 to here, including the correct file structure for this bot Added ftcscout (much better ftc stats) to the ftc commands Fixed datetime in ftc.py Removed toa, since toa pulls from ftc-events anyways. Deleted the toa section from config generation in main.py Fixed /stats issue with datetime (different level import between dozer2 and here)

guineawheek commented 7 months ago

small nit but the reason why import datetime is used over from datetime import datetime is that datetime provides other useful classes like timedelta, although i guess you could also do from datetime import datetime, timedelta

j5155 commented 7 months ago

Will try to address those issues tonight @guineawheek

skruglov2023 commented 7 months ago

Believe the latest comments have been resolved via latest merge with this patch branch

j5155 commented 5 months ago

OPR has been seperated out into it's own command, %ftc opr, aliased to %topr (alias broken in 142487a (#460) but should hopefully be fixed once stephan is free) does this address your concerns @guineawheek ?

guineawheek commented 5 months ago

i think opr is fine separately

skruglov2023 commented 5 months ago

%topr and %ftc opr should now be up to date on this PR, as per @j5155's message

j5155 commented 5 months ago

This PR is ready to merge as far as my planned code changes go. @devyntk looks like GitHub is still waiting for your review. We changed to f strings as you suggested, are there any other changes you would like?