search

FRCDiscord / Dozer

Omnipotent guild management bot for FIRST Discord servers
GNU General Public License v3.0
40 stars 45 forks source link

Moved attacks list to separate file #470

Closed silvanathecat closed 4 months ago

silvanathecat commented 5 months ago

this makes it easier to add and remove them. i also added a meme one about the chain this year just because i needed to change the file for the commit to work.

ignore my last pr, the attacks.py file wasn't there.

silvanathecat commented 5 months ago

haven't intrinsically tested it, but it should be fine... as long as i included all the required files...

devyntk commented 5 months ago

Im not sure how necessary this is.. I could see a much better argument for making the attacks a static variable at the top of the file, but a separate file for a ~200 line file to get smaller seems like overkill to me. If we're insistent on separating this out, it should at least be a static file (json or toml is my preference) that's not in source for easy customization.

silvanathecat commented 5 months ago

will rewrite for json (seems to be the project standard) on my lunch... ive also been thinking about possibly adding a command to add attacks and a better system for damage, will probably work on that... tomorrow? busy tonight after class, but could do it late.

gonna keep it as a draft until i do that though, and once the checks go through?