search

FRCTeam1967 / 2024Crescendo

Team 1967's robot code for the 2024 Crescendo game
0 stars 0 forks source link

RobotContainer::movePivotSafe doesn't do anything #10

Open drsandytoes opened 4 hours ago

drsandytoes commented 4 hours ago

https://github.com/FRCTeam1967/2024Crescendo/blob/cdccfde96d5f128416030d6f4ce314171f30ccc9/2024Crescendo/src/main/java/frc/robot/RobotContainer.java#L123

This doesn't do anything, AFAICT. It creates a new MovePivot command, but it's never scheduled so nothing is going to happen with it.

sanatiwary commented 3 hours ago

We use this in auto init, it was to try and combat the intake moving down randomly. We've commented it out now because our pivot isn't moving down at all but it's still in latest push's auto init uncommented

drsandytoes commented 1 hour ago

I don't think it was causing any harm. It just wasn't doing anything to help either.