FRCTeam2984 / DeepSpace2019

Vikings Robotics's code for DeepSpace 2019
MIT License
2 stars 10 forks source link

Missing components in SnapListener #55

Open xiaoeric opened 5 years ago

xiaoeric commented 5 years ago

https://github.com/FRCTeam2984/DeepSpace2019/blob/f3e4542aae9af44b7a09bac3295f2fa3329d8869/src/commands/snaplistener.py#L22-L24

Was this change committed separately from other changes to the Drive subsystem and Joystick? Driver (the joystick) doesn't have a getPOV() method and the Drive subsystem doesn't have a currentCommand field.

@ruwix Joe asked me to take a look at your fork and it doesn't seem to have these components either.

https://github.com/FRCTeam2984/DeepSpace2019/blob/f3e4542aae9af44b7a09bac3295f2fa3329d8869/src/commands/snaplistener.py#L16

Also I'm guessing that self.pov_port = 0 is just a temporary thing?

I'll take a closer look at the issue with turnToAngle later when I have time. Let me know if there are any code segments I should look at or details about the bug I should be aware of!