[ ] Code is complete, and naming of variables, methods and classes are readable by non-coder humans.
[ ] This code change has been tested and validated working as expected.
[ ] This code change has been reflected in robot documentation in the docs folder.
[ ] The questions below have all been answered.
[ ] The title of this PR has been updated to describe the change made, for example, [Subsystem or Command Name] Short description of change.
[ ] Assignees (usually yourself) have been assigned in the "Assignees" section to the right.
[ ] Relevant reviewers have been assigned under the "Reviewers" section at the right.
What is changing and why?
This cleans up the LEDs code to make it mergeable. It does not attempt to cleanup the LEDs subsystem, and does not try to figure out if there are better starting constants (i.e., why does ledsFrameCounter start at 1 instead of 0?). At some point, that additional cleanup should also be done.
How was this tested?
Is there anything the reviewer of this PR needs to know to validate that this code is correct?
What do your team members need to know about this?
Related Issues and PRs
Issue:
Related PRs:
Checklist
docsfolder.[Subsystem or Command Name] Short description of change.What is changing and why?
This cleans up the LEDs code to make it mergeable. It does not attempt to cleanup the LEDs subsystem, and does not try to figure out if there are better starting constants (i.e., why does
ledsFrameCounterstart at1instead of0?). At some point, that additional cleanup should also be done.How was this tested?
Is there anything the reviewer of this PR needs to know to validate that this code is correct?
What do your team members need to know about this?