FRCTeam3044 / 2024SwerveBase

Swerve Code for 2024 - Crescendo
Other
1 stars 0 forks source link

Do not set motor speeds from outside of a subsystem #15

Closed DavidDePauw1 closed 9 months ago

DavidDePauw1 commented 9 months ago

https://github.com/FRCTeam3044/2024SwerveBase/blob/ceddd96198dd04b30f3d4d0b13decdc8b7fb3c9c/src/main/java/frc/robot/commands/ElevatorManualControlCommand.java#L30

@ghorrocks217 Please make a method in the elevator subsystem to consume input, and comment what the expected values of the input should be. It is bad practice to manually set the speed of a motor from anywhere outside of the subsystem containing that motor.