search

FRCTeam4500 / 2019Robot

Robot code for the 2019 season
1 stars 0 forks source link

Hatch Intake Subsystem #4

Closed jmahari closed 5 years ago

jmahari commented 5 years ago

Need to build the hatch intake sub system

NicolasNewman commented 5 years ago

@Octillerysnacker Remove the 4 unneeded functions in the subsystem. There will never be a situation where we need them and they create unnecessary clutter.

Octillerysnacker commented 5 years ago

done, I think that's everything

NicolasNewman commented 5 years ago

Think again!

  1. In your subsystem, any parts that are declared should be private.
  2. In RobotMap, you should separate variables by subsystems. Add one of the multi line comments like the one for the drivetrain and put your Hatch variables under there.
  3. Since moving a piston is a single movement, isFinished should be true for each commands and instead of execute, you want to use initialized.
  4. It looks like you haven't mapped the buttons in OI.
Octillerysnacker commented 5 years ago

ok how about now