search

FREVA-CLINT / freva

The Free Evaluation System Framework (FreVa)
Other
10 stars 3 forks source link

typos #135

Closed eelucio closed 11 months ago

antarcticrainforest commented 1 year ago

In line 32 of the _databrowser.py file could you also change the sentence?

raise ValueError(f"Time select method has one of {methods}") from error

to raise ValueError(f"Time select method has to be one of {methods}") from error

eelucio commented 1 year ago

thanks!

antarcticrainforest commented 1 year ago

Can you fix the linting errors?

eelucio commented 1 year ago

When I do

$ make lint
mypy --install-types --non-interactive
Success: no issues found in 40 source files
black --check -t py310 src
All done! ✨ 🍰 ✨
84 files would be left unchanged.

I do not get linting errors for py310.

antarcticrainforest commented 1 year ago

What happens if you update black in your environment?

eelucio commented 1 year ago

same thing

$ python3 -m pip install -U black
...
    Uninstalling black-23.1.0:
      Successfully uninstalled black-23.1.0
Successfully installed black-23.7.0

$ make lint
mypy --install-types --non-interactive
Success: no issues found in 40 source files
black --check -t py310 src
All done! ✨ 🍰 ✨
84 files would be left unchanged.

the python I have is python 3.10.9

maybe I should reinstall the environment

antarcticrainforest commented 1 year ago

With a python3.11 env?

eelucio commented 1 year ago

I am currently updating the environemnt. As soon as it finishes I will try it again.

eelucio commented 1 year ago 
$ make lint
mypy --install-types --non-interactive
Success: no issues found in 40 source files
black --check -t py311 src
All done! ✨ 🍰 ✨
84 files would be left unchanged.
black --check -t py310 src
All done! ✨ 🍰 ✨
84 files would be left unchanged.
black --check -t py39 src
All done! ✨ 🍰 ✨
84 files would be left unchanged.
black --check -t py38 src
All done! ✨ 🍰 ✨
84 files would be left unchanged.
black --check -t py37 src
All done! ✨ 🍰 ✨
84 files would be left unchanged.
(freva-dev) [etor@ECEIZALAP /home/etor/work/freva/github/freva] (esgf-docu)
$ python --version
Python 3.11.4

I updated the enviornment:

mamba env update -f dev-environment.yml

I modified the make lint so it would run linters from 3.7 to 3.11 and there is nothing

UPDATE:

I did make install and now I am getting the errors

eelucio commented 1 year ago

Those are very old code snippets. I will work on their var annotation later in the week