Closed mo-dkrz closed 4 months ago
In reviewing the src/evaluation_system/api/plugin_manager.py
file, I've noticed an inconsistency in the naming convention used for the plugin name argument across different functions. It appears under various identifiers such as toolname
, tool_name
, and pluginname
. For the sake of code readability and maintainability, it might be beneficial to standardize the naming convention.
I have to find out why LSF
workload manager is getting called in a different way than other workload managers and why it uses _submit_job
function which others don't use the same approach and _submit_job
func is out of code coverage.
This issue would be open to make changes in src/evaluation_system/api/plugin_manager.py
and LSF
workload manager
according to our discussion with @antarcticrainforest in PR #190, we need to fix following issues before merging the request in review_mo branch:
exclude: '^src/evaluation_system/tests/crawl_my_data_test\.py$'
inmypy-pre-commit
unused_ignores
inmypy
django-stub
andrich-stub
in mypy pre-commitseperator
keyword inPrintableList
atsrc/evaluation_system/misc/utils.py
, we need to ensure it doesn't damage other parts of codesrc/evaluation_system/tests/esgf_test.py
need to be reverted.test_plugin_status
unit-test need to be fixedtbc ....