FREVA-CLINT / freva

The Free Evaluation System Framework (FreVa)
Other
10 stars 3 forks source link

Required Fixes and Enhancements Before Merging PR #190 #191

Closed mo-dkrz closed 4 months ago

mo-dkrz commented 6 months ago

according to our discussion with @antarcticrainforest in PR #190, we need to fix following issues before merging the request in review_mo branch:

tbc ....

mo-dkrz commented 6 months ago

In reviewing the src/evaluation_system/api/plugin_manager.py file, I've noticed an inconsistency in the naming convention used for the plugin name argument across different functions. It appears under various identifiers such as toolname, tool_name, and pluginname. For the sake of code readability and maintainability, it might be beneficial to standardize the naming convention.

mo-dkrz commented 6 months ago

I have to find out why LSF workload manager is getting called in a different way than other workload managers and why it uses _submit_job function which others don't use the same approach and _submit_job func is out of code coverage.

mo-dkrz commented 6 months ago

This issue would be open to make changes in src/evaluation_system/api/plugin_manager.py and LSF workload manager