FREVA-CLINT / freva

The Free Evaluation System Framework (FreVa)
Other
10 stars 3 forks source link

Qf #208

Open grooverdan opened 3 weeks ago

grooverdan commented 3 weeks ago

205 wasn't really ready. Hoping CI passes this time or gets further.

MoSHad91 commented 3 weeks ago

Hey @grooverdan. I need to give you further details. There are two workflows in the CI.

https://github.com/FREVA-CLINT/freva/blob/main/.github/workflows/build_containers.yml

and

https://github.com/FREVA-CLINT/freva/blob/main/.github/workflows/ci_job.yml

you are currently working on the first one, which idn why this workflow was not included in the CI list in your latest commit! (Creating container images) The second and main issue is about the second workflow ,ci_jobs.yml, is that a docker-compose is running there that uses the MariaDB image.

https://github.com/FREVA-CLINT/freva/blob/main/docker-compose.yaml#L4

To obtain a green CI, we updated it from lastest version to 11.3. Do you have any idea how to make it happen in docker-compose with the latest version of MariaDB?

ping @antarcticrainforest

grooverdan commented 3 weeks ago

At the moment 11.4 is the latest. ref.

If you want to test the RC in testing - quay.io/mariadb-foundation/mariadb-devel:verylatest (ref or :11.6-preview)

Getting a bit late here. So I'm off for the day but will help cleanup tomorrow if there's anything left.

MoSHad91 commented 6 days ago

@grooverdan sorry for delay in reply,

as I mentioned in my previous comment, when i changed the mariadb version from 11.3 to 11.4 or latest in [docker-compose.yaml]() i got mysql connection lost which i think this issue has been started from version 11.4. It seems u fixed the issue in build_jobs.yaml but the issue in ci_job.yaml is still left i have to mention, I don't know why we cannot see the logs of the following action when we refresh the tab, but to ensure we can see the logs, i copied and brought some of this test job here: https://github.com/MoSHad91/freva/actions/runs/9852346331/job/27200715031

No my question is, when we are using version 11.3 in docker-compose.yaml, it works well, but do not for 11.4 or latest! do u have any solution how to fix this in docker-compose.yaml

src/evaluation_system/tests/plugin_command_test.py::test_killed_jobs_set_to_broken Dummy tool was run with: {'number': None, 'the_number': 10, 'something': 'test', 'other': -10.0, 'input': None, 'variable': 'tas'}
[07/09/24 06:53:14] INFO     history, limit=10, since=None,       _history.py:94
                             until=None, entry_ids=None                         
FAILED
[07/09/24 06:53:15] ERROR    (2013, 'Lost connection to MySQL server utils.py:99
                             during query') - increase verbosity                
                             flags (-v) for more information                    
                             ╭─ Traceback (most recent call last) ─╮            
                             │ /usr/share/miniconda/lib/python3.12 │            
                             │ /site-packages/MySQLdb/connections. │            
                             │ py:261 in query                     │            
                             │                                     │            
                             │   258 │   │   # Since _mysql releas │            
                             │   259 │   │   if isinstance(query,  │            
                             │   260 │   │   │   query = bytes(que │            
                             │ ❱ 261 │   │   _mysql.connection.que │            
                             │   262 │                             │            
                             │   263 │   def _bytes_literal(self,  │            
                             │   264 │   │   assert isinstance(bs, │            
                             ╰─────────────────────────────────────╯            
                             OperationalError: (2013, 'Lost                     
                             connection to MySQL server during                  
                             query')                                            
src/evaluation_system/tests/plugin_command_test.py::test_list_tools FAILED
src/evaluation_system/tests/plugin_command_test.py::test_run_pyclientplugin FAILED
src/evaluation_system/tests/plugin_command_test.py::test_run_pyclientplugin ERROR
src/evaluation_system/tests/plugin_command_test.py::test_plugin_status FAILED
src/evaluation_system/tests/plugin_command_test.py::test_plugin_output FAILED
src/evaluation_system/tests/plugin_command_test.py::test_plugin_output ERROR
src/evaluation_system/tests/plugin_command_test.py::test_empty_status FAILED
src/evaluation_system/tests/plugin_command_test.py::test_empty_status ERROR
                    ERROR    (2013, 'Lost connection to MySQL server utils.py:99
                             during query') - increase verbosity                
                             flags (-v) for more information                    
                             ╭─ Traceback (most recent call last) ─╮            
                             │ /usr/share/miniconda/lib/python3.12 │            
                             │ /site-packages/MySQLdb/connections. │            
                             │ py:261 in query                     │            
                             │                                     │            
                             │   258 │   │   # Since _mysql releas │            
                             │   259 │   │   if isinstance(query,  │            
                             │   260 │   │   │   query = bytes(que │            
                             │ ❱ 261 │   │   _mysql.connection.que │            
                             │   262 │                             │            
                             │   263 │   def _bytes_literal(self,  │            
                             │   264 │   │   assert isinstance(bs, │            
                             ╰─────────────────────────────────────╯            
                             OperationalError: (2013, 'Lost                     
                             connection to MySQL server during                  
                             query')