FREVA-CLINT / freva

The Free Evaluation System Framework (FreVa)
Other
10 stars 3 forks source link

Preparation for a new cli machinary #26

Closed antarcticrainforest closed 1 year ago

antarcticrainforest commented 1 year ago

In order to prepare freva for a new command line interface I deleted some functionality that isn't used anymore:

Note: If the functionality for tex2html and check4broken runs should be re-added then I would say we do this after the actual refactoring of the cli. I am planning on changing the cli to be able to plug in additional freva functionality without modifying the freva core base. If we think these tools are still helpful, then they could be added via the new machinery.

lgtm-com[bot] commented 1 year ago

This pull request introduces 2 alerts and fixes 4 when merging 4e50dde1049227e925c581a06ef4151212971aa5 into e52b27e9e995a4c5e30f01056cfdc6f699be1abc - view on LGTM.com

new alerts:

fixed alerts:

eelucio commented 1 year ago

I have been looking for the text2html functionality but so far I did not find it in the repo, so I have no way to tell what it was doing. I have not used check4broken_runs ever, nor I remember any of us using it either, I guess we would not needed it, as you say.

Okey for solr ingest.

I would say that the only functionality that some users might ask for to be re stablished would be the pull request, but I am pretty sure that is going to be a no-no from your side (and Brian and Adnrej as well): I guess that the workaround for that is just to be available to respond them in order to approve and introduce changes, in any case.

so, LGTM