FRIBDAQ / NSCLDAQ

0 stars 1 forks source link

No error message if deletion of links in current fails. #143

Closed rfoxkendo closed 3 months ago

rfoxkendo commented 5 months ago

ReadoutGUI maintains a directory structure for its event files which includes a current directory that, while a recorded run is active, holds links to the event files being built up in experiment/runn.

At the end of a recorded run, those links are removed, however there is no error message if that fails. Specifically in main/daq/readoutgui/eventlogbundle.tcl, Eventlog::FinalizeRun the code that does that is:

      #  Remove any links to event files in the srcdir

        set  fileBaseName [::ExpFileSystem::genEventfileBasename $run]
        set  eventFiles [glob -nocomplain [file join $srcdir ${fileBaseName}*.evt]]
        foreach file $eventFiles {
          catch {file delete -force $file}
        }

where there's nothing done if the catch reports an error. At the very least a message should be logged to the output window and maybe after collecting all failures a tk_messageBox should call attentinon to this.

rfoxkendo commented 3 months ago

The prior commit resolves this. Pulling into 12.1-dev