FRO5401 / PowerUp2018

2 stars 0 forks source link

[newOi][ Bombay ] refactor #27

Closed DBombay closed 6 years ago

DBombay commented 6 years ago

STATUS

IN PROGRESS

DESCRIPTION

This is a refactor of the OI code, which condenses it down to 3 functions. I didn't find any of the controller methods being called in other files, so integration should be super easy.

This needs to be tested!

FILES THAT CONTAINTED MERGE CONFLICTS

-

TO DO

ptoil commented 6 years ago

The code has errors due to exclusion of the semicolon (which Java syntax needs) and the lack of data types for the parameters. I am assuming the userMap parameter needs an Joystick object. However, when we use the xboxAxis, xboxButton, or xboxDPad method, we cannot cross over files to get the Joystick object in OI.

jxfireruby commented 6 years ago

A Button object should be created for each individual button because the methods of the Button class is useful. I do not think an instance variable needs to be made to get value from the RobotMap. I think directly using the RobotMap variable is fine.