search

FRRouting / frr

The FRRouting Protocol Suite
https://frrouting.org/
Other
3.38k stars 1.26k forks source link

FRR 8.1 - frr-reload fails for isis - Mandatory node "area-tag" instance does not exist #10133

Open c-po opened 3 years ago

c-po commented 3 years ago

Describe the bug

In VyOS we utilize frr-reload for loading and applying configuration changes. While upgrading to FRR 8.1 it was discovered that same reload commands fail b/c frr-reload throws a return code != 0 and itself reports some issues.

When ISIS is configured on the router and should be removed from the running configuration, FRR tells us:

2021-11-27 10:42:50,504   ERROR: "interface eth2 --  no" we failed to remove this command
2021-11-27 10:42:50,505   ERROR: % Configuration failed.

Error type: validation
Error description: YANG error(s):
 Mandatory node "area-tag" instance does not exist.
 YANG path: Schema location /frr-interface:lib/interface/frr-isisd:isis/area-tag.

This one is probably related to #10132

To Reproduce

Prepare FRR with ISIS setup - load via frr-reload.py

isis.txt

interface eth0
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
interface eth0.201
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
interface eth1
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
interface eth2
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
router isis VyOS
 net 49.0001.1921.6800.1002.00
 lsp-mtu 1497
 spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75
exit
!
sudo /usr/lib/frr/frr-reload.py --reload --daemon isisd --debug --stdout isis.txt

Now unload ISIS configuration via frr-reload

no-isis.txt

!
sudo /usr/lib/frr/frr-reload.py --reload --daemon isisd --debug --stdout no-isis.txt

Expected behavior

Unloading of the ISIS configuration should work in the first run without reporting an error to the user.

Screenshots

cpo@LR1.wue3:~$ sudo /usr/lib/frr/frr-reload.py --reload --daemon isisd --debug --stdout isis.txt
2021-11-27 10:40:46,794  INFO: Called via "Namespace(input=None, reload=True, test=False, debug=True, log_level='info', stdout=True, pathspace=None, filename='isis.txt', overwrite=False, bindir='/usr/bin', confdir='/etc/frr', rundir='/var/run/frr', vty_socket=None, daemon='isisd', test_reset=False)"
2021-11-27 10:40:46,795  INFO: Loading Config object from file isis.txt
2021-11-27 10:40:47,249 DEBUG: LINE interface eth0                                    : enter context ['interface eth0']
2021-11-27 10:40:47,249 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth0']
2021-11-27 10:40:47,250 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth0']
2021-11-27 10:40:47,250 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth0']
2021-11-27 10:40:47,251 DEBUG: LINE exit                                              : exit context ['interface eth0']
2021-11-27 10:40:47,252 DEBUG: LINE interface eth0.201                                : enter context ['interface eth0.201']
2021-11-27 10:40:47,252 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth0.201']
2021-11-27 10:40:47,252 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth0.201']
2021-11-27 10:40:47,252 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth0.201']
2021-11-27 10:40:47,252 DEBUG: LINE exit                                              : exit context ['interface eth0.201']
2021-11-27 10:40:47,252 DEBUG: LINE interface eth1                                    : enter context ['interface eth1']
2021-11-27 10:40:47,252 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth1']
2021-11-27 10:40:47,252 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth1']
2021-11-27 10:40:47,252 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth1']
2021-11-27 10:40:47,252 DEBUG: LINE exit                                              : exit context ['interface eth1']
2021-11-27 10:40:47,253 DEBUG: LINE interface eth2                                    : enter context ['interface eth2']
2021-11-27 10:40:47,253 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth2']
2021-11-27 10:40:47,253 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth2']
2021-11-27 10:40:47,253 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth2']
2021-11-27 10:40:47,253 DEBUG: LINE exit                                              : exit context ['interface eth2']
2021-11-27 10:40:47,253 DEBUG: LINE router isis VyOS                                  : enter context ['router isis VyOS']
2021-11-27 10:40:47,253 DEBUG: LINE net 49.0001.1921.6800.1002.00                     : add to current context ['router isis VyOS']
2021-11-27 10:40:47,253 DEBUG: LINE lsp-mtu 1497                                      : add to current context ['router isis VyOS']
2021-11-27 10:40:47,253 DEBUG: LINE spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75: add to current context ['router isis VyOS']
2021-11-27 10:40:47,253 DEBUG: LINE exit                                              : exit context ['router isis VyOS']
2021-11-27 10:40:47,719 DEBUG: New Frr Config
interface eth0
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth0.201
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth1
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth2
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
router isis VyOS
net 49.0001.1921.6800.1002.00
lsp-mtu 1497
spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75
exit
!

end

2021-11-27 10:40:47,719  INFO: Loading Config object from vtysh show running
2021-11-27 10:40:48,185 DEBUG: LINE frr version 8.1                                   : single-line context
2021-11-27 10:40:48,185 DEBUG: LINE frr defaults traditional                          : single-line context
2021-11-27 10:40:48,186 DEBUG: LINE hostname LR1.wue3                                 : single-line context
2021-11-27 10:40:48,186 DEBUG: LINE service integrated-vtysh-config                   : single-line context
2021-11-27 10:40:48,186 DEBUG: Running Frr Config (Pass #0)
frr version 8.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
end
2021-11-27 10:40:48,188  INFO: "frr version 8.1" cannot be removed
2021-11-27 10:40:48,188  INFO: "frr defaults traditional" cannot be removed
2021-11-27 10:40:48,188  INFO: "service integrated-vtysh-config" cannot be removed
2021-11-27 10:40:48,653  INFO: Executed "no hostname LR1.wue3"
2021-11-27 10:40:48,655  INFO: /var/run/frr/reload-ESDORW.txt content
['interface eth0\n',
 'interface eth0\n ip router isis VyOS\n',
 'interface eth0\n ipv6 router isis VyOS\n',
 'interface eth0\n isis network point-to-point\n',
 'interface eth0.201\n',
 'interface eth0.201\n ip router isis VyOS\n',
 'interface eth0.201\n ipv6 router isis VyOS\n',
 'interface eth0.201\n isis network point-to-point\n',
 'interface eth1\n',
 'interface eth1\n ip router isis VyOS\n',
 'interface eth1\n ipv6 router isis VyOS\n',
 'interface eth1\n isis network point-to-point\n',
 'interface eth2\n',
 'interface eth2\n ip router isis VyOS\n',
 'interface eth2\n ipv6 router isis VyOS\n',
 'interface eth2\n isis network point-to-point\n',
 'router isis VyOS\n',
 'router isis VyOS\n net 49.0001.1921.6800.1002.00\n',
 'router isis VyOS\n lsp-mtu 1497\n',
 'router isis VyOS\n'
 ' spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 '
 'time-to-learn 75\n']
2021-11-27 10:40:49,233  INFO: Loading Config object from vtysh show running
2021-11-27 10:40:49,700 DEBUG: LINE frr version 8.1                                   : single-line context
2021-11-27 10:40:49,701 DEBUG: LINE frr defaults traditional                          : single-line context
2021-11-27 10:40:49,701 DEBUG: LINE hostname LR1.wue3                                 : single-line context
2021-11-27 10:40:49,701 DEBUG: LINE service integrated-vtysh-config                   : single-line context
2021-11-27 10:40:49,701 DEBUG: LINE interface eth0                                    : enter context ['interface eth0']
2021-11-27 10:40:49,701 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth0']
2021-11-27 10:40:49,701 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth0']
2021-11-27 10:40:49,701 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth0']
2021-11-27 10:40:49,701 DEBUG: LINE exit                                              : exit context ['interface eth0']
2021-11-27 10:40:49,702 DEBUG: LINE interface eth0.201                                : enter context ['interface eth0.201']
2021-11-27 10:40:49,702 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth0.201']
2021-11-27 10:40:49,702 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth0.201']
2021-11-27 10:40:49,702 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth0.201']
2021-11-27 10:40:49,702 DEBUG: LINE exit                                              : exit context ['interface eth0.201']
2021-11-27 10:40:49,702 DEBUG: LINE interface eth1                                    : enter context ['interface eth1']
2021-11-27 10:40:49,702 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth1']
2021-11-27 10:40:49,702 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth1']
2021-11-27 10:40:49,702 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth1']
2021-11-27 10:40:49,702 DEBUG: LINE exit                                              : exit context ['interface eth1']
2021-11-27 10:40:49,702 DEBUG: LINE interface eth2                                    : enter context ['interface eth2']
2021-11-27 10:40:49,703 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth2']
2021-11-27 10:40:49,703 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth2']
2021-11-27 10:40:49,703 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth2']
2021-11-27 10:40:49,703 DEBUG: LINE exit                                              : exit context ['interface eth2']
2021-11-27 10:40:49,703 DEBUG: LINE router isis VyOS                                  : enter context ['router isis VyOS']
2021-11-27 10:40:49,703 DEBUG: LINE net 49.0001.1921.6800.1002.00                     : add to current context ['router isis VyOS']
2021-11-27 10:40:49,703 DEBUG: LINE spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75: add to current context ['router isis VyOS']
2021-11-27 10:40:49,703 DEBUG: LINE exit                                              : exit context ['router isis VyOS']
2021-11-27 10:40:49,703 DEBUG: Running Frr Config (Pass #1)
frr version 8.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
interface eth0
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth0.201
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth1
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth2
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
router isis VyOS
net 49.0001.1921.6800.1002.00
spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75
exit
!
end
2021-11-27 10:40:49,704  INFO: "frr version 8.1" cannot be removed
2021-11-27 10:40:49,704  INFO: "frr defaults traditional" cannot be removed
2021-11-27 10:40:49,704  INFO: "service integrated-vtysh-config" cannot be removed
2021-11-27 10:40:49,705  INFO: /var/run/frr/reload-IVVPPN.txt content
['router isis VyOS\n lsp-mtu 1497\n',
 'interface eth0\n',
 'interface eth0\n ip router isis VyOS\n',
 'interface eth0\n ipv6 router isis VyOS\n',
 'interface eth0\n isis network point-to-point\n',
 'interface eth0.201\n',
 'interface eth0.201\n ip router isis VyOS\n',
 'interface eth0.201\n ipv6 router isis VyOS\n',
 'interface eth0.201\n isis network point-to-point\n',
 'interface eth1\n',
 'interface eth1\n ip router isis VyOS\n',
 'interface eth1\n ipv6 router isis VyOS\n',
 'interface eth1\n isis network point-to-point\n',
 'interface eth2\n',
 'interface eth2\n ip router isis VyOS\n',
 'interface eth2\n ipv6 router isis VyOS\n',
 'interface eth2\n isis network point-to-point\n',
 'router isis VyOS\n',
 'router isis VyOS\n net 49.0001.1921.6800.1002.00\n',
 'router isis VyOS\n lsp-mtu 1497\n',
 'router isis VyOS\n'
 ' spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 '
 'time-to-learn 75\n']

Verify loaded config

cpo@LR1.wue3:~$ vtysh -c "show run"
Building configuration...

Current configuration:
!
frr version 8.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
interface eth0
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
interface eth0.201
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
interface eth1
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
interface eth2
 ip router isis VyOS
 ipv6 router isis VyOS
 isis network point-to-point
exit
!
router isis VyOS
 net 49.0001.1921.6800.1002.00
 spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75
exit
!
end

Unload the configuration

cpo@LR1.wue3:~$ sudo /usr/lib/frr/frr-reload.py --reload --daemon isisd --debug --stdout no-isis.txt
2021-11-27 10:42:37,313  INFO: Called via "Namespace(input=None, reload=True, test=False, debug=True, log_level='info', stdout=True, pathspace=None, filename='no-isis.txt', overwrite=False, bindir='/usr/bin', confdir='/etc/frr', rundir='/var/run/frr', vty_socket=None, daemon='isisd', test_reset=False)"
2021-11-27 10:42:37,314  INFO: Loading Config object from file no-isis.txt
2021-11-27 10:42:38,237 DEBUG: New Frr Config
!

end

2021-11-27 10:42:38,237  INFO: Loading Config object from vtysh show running
2021-11-27 10:42:38,725 DEBUG: LINE frr version 8.1                                   : single-line context
2021-11-27 10:42:38,727 DEBUG: LINE frr defaults traditional                          : single-line context
2021-11-27 10:42:38,727 DEBUG: LINE hostname LR1.wue3                                 : single-line context
2021-11-27 10:42:38,728 DEBUG: LINE service integrated-vtysh-config                   : single-line context
2021-11-27 10:42:38,728 DEBUG: LINE interface eth0                                    : enter context ['interface eth0']
2021-11-27 10:42:38,728 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth0']
2021-11-27 10:42:38,728 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth0']
2021-11-27 10:42:38,728 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth0']
2021-11-27 10:42:38,728 DEBUG: LINE exit                                              : exit context ['interface eth0']
2021-11-27 10:42:38,728 DEBUG: LINE interface eth0.201                                : enter context ['interface eth0.201']
2021-11-27 10:42:38,728 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth0.201']
2021-11-27 10:42:38,728 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth0.201']
2021-11-27 10:42:38,728 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth0.201']
2021-11-27 10:42:38,729 DEBUG: LINE exit                                              : exit context ['interface eth0.201']
2021-11-27 10:42:38,729 DEBUG: LINE interface eth1                                    : enter context ['interface eth1']
2021-11-27 10:42:38,729 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth1']
2021-11-27 10:42:38,729 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth1']
2021-11-27 10:42:38,729 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth1']
2021-11-27 10:42:38,729 DEBUG: LINE exit                                              : exit context ['interface eth1']
2021-11-27 10:42:38,729 DEBUG: LINE interface eth2                                    : enter context ['interface eth2']
2021-11-27 10:42:38,729 DEBUG: LINE ip router isis VyOS                               : add to current context ['interface eth2']
2021-11-27 10:42:38,729 DEBUG: LINE ipv6 router isis VyOS                             : add to current context ['interface eth2']
2021-11-27 10:42:38,729 DEBUG: LINE isis network point-to-point                       : add to current context ['interface eth2']
2021-11-27 10:42:38,729 DEBUG: LINE exit                                              : exit context ['interface eth2']
2021-11-27 10:42:38,730 DEBUG: LINE router isis VyOS                                  : enter context ['router isis VyOS']
2021-11-27 10:42:38,730 DEBUG: LINE net 49.0001.1921.6800.1002.00                     : add to current context ['router isis VyOS']
2021-11-27 10:42:38,730 DEBUG: LINE spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75: add to current context ['router isis VyOS']
2021-11-27 10:42:38,730 DEBUG: LINE exit                                              : exit context ['router isis VyOS']
2021-11-27 10:42:38,730 DEBUG: Running Frr Config (Pass #0)
frr version 8.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
interface eth0
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth0.201
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth1
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
interface eth2
ip router isis VyOS
ipv6 router isis VyOS
isis network point-to-point
exit
!
router isis VyOS
net 49.0001.1921.6800.1002.00
spf-delay-ietf init-delay 50 short-delay 100 long-delay 200 holddown 10 time-to-learn 75
exit
!
end
2021-11-27 10:42:38,731  INFO: "frr version 8.1" cannot be removed
2021-11-27 10:42:38,732  INFO: "frr defaults traditional" cannot be removed
2021-11-27 10:42:38,732  INFO: "service integrated-vtysh-config" cannot be removed
2021-11-27 10:42:39,196  INFO: Executed "no hostname LR1.wue3"
2021-11-27 10:42:39,663  INFO: Executed "interface eth0  no ip router isis VyOS"
2021-11-27 10:42:40,136  INFO: Executed "interface eth0  no ipv6 router isis VyOS"
2021-11-27 10:42:40,609  INFO: Failed to execute interface eth0  no isis network point-to-point
2021-11-27 10:42:41,086  INFO: Failed to execute interface eth0  no isis network
2021-11-27 10:42:41,556  INFO: Failed to execute interface eth0  no isis
2021-11-27 10:42:42,026  INFO: Failed to execute interface eth0  no
2021-11-27 10:42:42,027   ERROR: "interface eth0 --  no" we failed to remove this command
2021-11-27 10:42:42,027   ERROR: % Configuration failed.

Error type: validation
Error description: YANG error(s):
 Mandatory node "area-tag" instance does not exist.
 YANG path: Schema location /frr-interface:lib/interface/frr-isisd:isis/area-tag.

2021-11-27 10:42:42,498  INFO: Executed "interface eth0.201  no ip router isis VyOS"
2021-11-27 10:42:42,975  INFO: Executed "interface eth0.201  no ipv6 router isis VyOS"
2021-11-27 10:42:43,447  INFO: Failed to execute interface eth0.201  no isis network point-to-point
2021-11-27 10:42:43,941  INFO: Failed to execute interface eth0.201  no isis network
2021-11-27 10:42:44,409  INFO: Failed to execute interface eth0.201  no isis
2021-11-27 10:42:44,877  INFO: Failed to execute interface eth0.201  no
2021-11-27 10:42:44,878   ERROR: "interface eth0.201 --  no" we failed to remove this command
2021-11-27 10:42:44,878   ERROR: % Configuration failed.

Error type: validation
Error description: YANG error(s):
 Mandatory node "area-tag" instance does not exist.
 YANG path: Schema location /frr-interface:lib/interface/frr-isisd:isis/area-tag.

2021-11-27 10:42:45,348  INFO: Executed "interface eth1  no ip router isis VyOS"
2021-11-27 10:42:45,826  INFO: Executed "interface eth1  no ipv6 router isis VyOS"
2021-11-27 10:42:46,294  INFO: Failed to execute interface eth1  no isis network point-to-point
2021-11-27 10:42:46,763  INFO: Failed to execute interface eth1  no isis network
2021-11-27 10:42:47,230  INFO: Failed to execute interface eth1  no isis
2021-11-27 10:42:47,698  INFO: Failed to execute interface eth1  no
2021-11-27 10:42:47,698   ERROR: "interface eth1 --  no" we failed to remove this command
2021-11-27 10:42:47,699   ERROR: % Configuration failed.

Error type: validation
Error description: YANG error(s):
 Mandatory node "area-tag" instance does not exist.
 YANG path: Schema location /frr-interface:lib/interface/frr-isisd:isis/area-tag.

2021-11-27 10:42:48,170  INFO: Executed "interface eth2  no ip router isis VyOS"
2021-11-27 10:42:48,638  INFO: Executed "interface eth2  no ipv6 router isis VyOS"
2021-11-27 10:42:49,107  INFO: Failed to execute interface eth2  no isis network point-to-point
2021-11-27 10:42:49,574  INFO: Failed to execute interface eth2  no isis network
2021-11-27 10:42:50,039  INFO: Failed to execute interface eth2  no isis
2021-11-27 10:42:50,504  INFO: Failed to execute interface eth2  no
2021-11-27 10:42:50,504   ERROR: "interface eth2 --  no" we failed to remove this command
2021-11-27 10:42:50,505   ERROR: % Configuration failed.

Error type: validation
Error description: YANG error(s):
 Mandatory node "area-tag" instance does not exist.
 YANG path: Schema location /frr-interface:lib/interface/frr-isisd:isis/area-tag.

2021-11-27 10:42:50,969  INFO: Executed "no router isis VyOS"
2021-11-27 10:42:50,970  INFO: Loading Config object from vtysh show running
2021-11-27 10:42:51,435 DEBUG: LINE frr version 8.1                                   : single-line context
2021-11-27 10:42:51,436 DEBUG: LINE frr defaults traditional                          : single-line context
2021-11-27 10:42:51,436 DEBUG: LINE hostname LR1.wue3                                 : single-line context
2021-11-27 10:42:51,436 DEBUG: LINE service integrated-vtysh-config                   : single-line context
2021-11-27 10:42:51,436 DEBUG: Running Frr Config (Pass #1)
frr version 8.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
end
2021-11-27 10:42:51,436  INFO: "frr version 8.1" cannot be removed
2021-11-27 10:42:51,437  INFO: "frr defaults traditional" cannot be removed
2021-11-27 10:42:51,437  INFO: "service integrated-vtysh-config" cannot be removed

Config is unloaded

cpo@LR1.wue3:~$ vtysh -c "show run"
Building configuration...

Current configuration:
!
frr version 8.1
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
end

Versions

Additional context

idryzhov commented 3 years ago

Not related to #10132. This is an ISIS specific problem, not a common frr-reload thing.

You wrote that you discovered this while upgrading to 8.1. Do you mean that this worked for you on 8.0?

c-po commented 3 years ago

You wrote that you discovered this while upgrading to 8.1. Do you mean that this worked for you on 8.0?

Sorry I was a bit unclear - this issue is also present on FRR 8.0 (latest commit from stable/8.0 e6526a625f530)

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

frrbot[bot] commented 2 years ago

This issue will be automatically closed in the specified period unless there is further activity.

idryzhov commented 1 year ago

This problem still happens.

The reason is that frr-reload at first executes no ip router isis VyOS and no ipv6 router isis VyOS which delete the whole ISIS configuration from the interface, and after that tries to execute no isis network point-to-point which fails because the config is not there anymore.

The correct fix would probably be to allow configuration of ISIS parameters on an interface even without configuring ip router isis/ipv6 router isis on that interface before that. But as a fast fix one could update frr-reload.py to ignore all no ISIS commands after both ip router isis and ipv6 router isis are deleted from the interface.