Not selected routes omitted from VTY shell FIB listing

davischw commented 6 months ago

Description

The show ipv6 route command lists more routes marked with * as present in the FIB than the show ipv6 fib command, because the later omits routes not selected as best forwarding paths.

Version

master, 9.1.0, 8.5.4

How to reproduce

r1# show ipv6 route
Codes: K - kernel route, C - connected, S - static,
       R - RIPng, O - OSPFv3, I - IS-IS, B - BGP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, F - PBR,
       f - OpenFabric,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

C>* 2001::/64 is directly connected, enp1s0, 00:00:04
C>* 2002::/64 is directly connected, enp2s0, 00:00:04
C * fe80::/64 is directly connected, enp2s0, 00:00:10
C>* fe80::/64 is directly connected, enp1s0, 00:00:10

frr8-build# show ipv6 fib
Codes: K - kernel route, C - connected, S - static,
       R - RIPng, O - OSPFv3, I - IS-IS, B - BGP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, F - PBR,
       f - OpenFabric,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure

C>* 2001::/64 is directly connected, enp1s0, 00:01:16
C>* 2002::/64 is directly connected, enp2s0, 00:01:16
C>* fe80::/64 is directly connected, enp1s0, 00:01:22

Expected behavior

The show ipv6 fib output should represent the actual state of the FIB and therefore also include routes installed in the FIB, but not selected as best forwarding path.

Actual behavior

Routes not selected as best forwarding path are omitted from VTY shell FIB listing.

Additional context

The output of not selected routes is suppressed for multiple show commands: https://github.com/FRRouting/frr/blob/b02d946db1e2241fc18bdf0a062672324609f2db/zebra/zebra_vty.c#L541 https://github.com/FRRouting/frr/blob/b02d946db1e2241fc18bdf0a062672324609f2db/zebra/zebra_vty.c#L849 https://github.com/FRRouting/frr/blob/b02d946db1e2241fc18bdf0a062672324609f2db/zebra/zebra_vty.c#L896

Checklist

[X] I have searched the open issues for this bug.
[X] I have not included sensitive information in this report.

github-actions[bot] commented 3 weeks ago

This issue is stale because it has been open 180 days with no activity. Comment or remove the autoclose label in order to avoid having this issue closed.

frrbot[bot] commented 3 weeks ago

This issue will be automatically closed in the specified period unless there is further activity.

FRRouting / frr