FRRouting / frr

The FRRouting Protocol Suite
https://frrouting.org/
Other
3.12k stars 1.2k forks source link

zebra: fix update nexthop-group fib flag value #16332

Open pguibert6WIND opened 5 days ago

pguibert6WIND commented 5 days ago

A nexthop-group does not display the 'fib' flag value of its nexthops.

nexthop-group A nexthop 192.168.1.55 loop1 exit

observed:

ubuntu2204# show nexthop-group rib 181818168 json { "181818168":{ "type":"sharp", "refCount":1, "uptime":"00:00:17", "vrf":"default", "valid":true, "installed":true, "depends":[ 528 ], "nexthops":[ { "flags":3, "fib":true, "ip":"192.168.1.55", "afi":"ipv4", "interfaceIndex":3, "interfaceName":"loop1", "vrf":"default", "active":true, "weight":1 } ] } }

expected:

ubuntu2204# show nexthop-group rib 181818168 json { "181818168":{ "type":"sharp", "refCount":1, "uptime":"00:00:25", "vrf":"default", "valid":true, "installed":true, "depends":[ 574 ], "nexthops":[ { "flags":3, "fib":true, "ip":"192.168.1.55", "afi":"ipv4", "interfaceIndex":3, "interfaceName":"loop1", "vrf":"default", "active":true, "weight":1 } ] } }

Fix this by refreshing the fib flag value of its nexthops, when the dataplane result indicate the nexthop-group is installed.

donaldsharp commented 5 days ago

the before and after output looks the same to me. Can you fix or better highlight what I am missing?

ton31337 commented 4 days ago

@Mergifyio backport dev/10.1

mergify[bot] commented 4 days ago

backport dev/10.1

🟠 Waiting for conditions to match

- [ ] `merged` [📌 backport requirement]
pguibert6WIND commented 2 days ago

@chiragshah6 , any feedback ?