Recent commit breaks nhrp_redundancy topotest

donaldsharp commented 2 months ago

Description

This commit:

commit af54901405474b0623bda1899424ec18a3240c71 (origin/pr/16640)
Author: Louis Scalbert <louis.scalbert@6wind.com>
Date:   Fri Aug 23 16:05:45 2024 +0200

    nhrpd: fix sending /32 shortcut

Has broken nhrp_redundancy topotest. This is because the test was looking for iptables but the coder and the CI system does not have it installed so the test is being skipped.

This commit needs to either be fixed ( so the test passes again ) or the test needs to be fixed, if it is wrong.

Additionally the ci system will add the iptables package and this test will start failing so this must be fixed.

Version

latest master

How to reproduce

run nrhp_redundancy with iptables installed

Expected behavior

test to pass

Actual behavior

test does not pass

Additional context

No response

Checklist

[X] I have searched the open issues for this bug.
[X] I have not included sensitive information in this report.

donaldsharp commented 2 months ago

@louis-6wind this is your commit that exhibits this problem. This must be fixed or we will back out the above commit.

louis-6wind commented 2 months ago

Thank you @donaldsharp for noticing. The test was incorrect

FRRouting / frr