FRRouting / frr

The FRRouting Protocol Suite
https://frrouting.org/
Other
3.27k stars 1.24k forks source link

checkpatch / remove quoted string split across lines #1794

Closed pguibert6WIND closed 6 years ago

pguibert6WIND commented 6 years ago

sometimes, we need to split the quote in two. because we are in indented code, and the message we carry is big.

I think it would really bring improvements if that rule is not applied to frr code.

qlyoung commented 6 years ago

https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings

...never break user-visible strings such as printk messages, because that breaks the ability to grep for them.

If it's really a degenerate case, consider reducing the level of indentation, or defining your string literals on a separate line.

donaldsharp commented 6 years ago

I agree w/ Quentin, the debug line should be on one line to allow for grepping. I find it extremely useful to do this and use it often.