eigrp: FSM event handling limited to EIGRP_FSM_STATE_PASSIVE

[pacovn]

After running PVS-Studio (trial version) I've found at eigrp_fsm_event_lr_fcs() function (eigrpd/eigrp_fsm.c) that the state is overwriting always to EIGRP_FSM_STATE_PASSIVE, so it makes dead code half of the function (e.g. if (prefix->state == EIGRP_FSM_STATE_ACTIVE_2)).

Is this because being a known limitation, or because of a mistake (?)

[lucize]

@pacovn I can only say that for now eigrp_fsm.c is crashing the eigrp https://github.com/FRRouting/frr/issues/1348

[pacovn]

@lucize thank you

[lucize]

if you think about a fix, my network is usually crashing the module pretty rapidly

[pacovn]

I'm not an expert in eigrp, but I'll keep my eyes open on that

[donaldsharp]

@pacovn probably a little of column a a little of column b.

EIGRP needs some serious work still.

[lucize]

@donaldsharp do you have some more spare time to give a little love to eigrp ? 😄

[donaldsharp]

Unfortunately my time has been at a severe premium. I suspect we'll be getting some EIGRP love in the not too distant future though. @diivious any thoughts on this?

[diivious]

Hey Donald,

I have finally started working on EIGRP!!

My 12 hour days are starting to slow down a bit. On my flight ask week, I began studying the code - this week I have starting some restructuring. I have see a lot I want to work on, the first is to do some clean up, then TLV3, then some state machine fixes.

About about 3/4 done with the TLV1 restructure needed so i can implement the TLV3 stuff. Also i have setup a lab with a number of EIGRP routers so i can do some compatibility testing with the changes I am making.

---

From: Donald Sharp notifications@github.com Sent: Saturday, August 25, 2018 2:36 PM To: FRRouting/frr Cc: Donnie Savage; Mention Subject: Re: [FRRouting/frr] eigrp: FSM event handling limited to EIGRP_FSM_STATE_PASSIVE (#2606)

Unfortunately my time has been at a severe premium. I suspect we'll be getting some EIGRP love in the not too distant future though. @diivioushttps://github.com/diivious any thoughts on this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/FRRouting/frr/issues/2606#issuecomment-415988411, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGR_BpkUoqzNoatohLG4VHHPLL6m8Gdxks5uUZkrgaJpZM4U_kiz.

[donaldsharp]

@diivious I thought that is what you were alluding to in your tweet. I hope to see some code!

[diivious]

Yup - coding testing testing ... course if it compiled on a mac it would make it so much faster; TGF VMs.....ha

[donaldsharp]

So we had someone start working on getting FRR compiling on a mac. We would of course love for anyone to do this work too :)

Might not be too much of a stretch to make it work.