lib: NS backend outputs spurious error messages

[cfra]

On OpenWRT, when I run any of FRR's daemons, I receive log output like following, although I do not have selected the NS backend:

2018/08/25 14:39:47 errors: ZEBRA: NS initialization failure 2(No such file or directory)

I think this should be fixed, but I am not sure what the correct fix is. I see that there is a function have_netns which would behave better, but it doesn't get called by ns_init.

[pguibert6WIND]

I will have a look at this. is it affecting the behaviour, or is it just an error message ? I mean error message may just be warning message .?

[cfra]

I checked and it does not seem to affect the behavior. Is the default ns used at all if we are not using the NS backend? A more extended log of FRR startup looks like this:

procd: /etc/rc.d/S60frr: frr.init: Starting eigrpd ... 2018/08/27 09:33:35 errors: EIGRP: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting isisd ... 2018/08/27 09:33:36 errors: ISIS: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting ldpd ... 2018/08/27 09:33:36 errors: LDP: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting nhrpd ... 2018/08/27 09:33:37 errors: NHRP: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting ospfd ... 2018/08/27 09:33:37 errors: OSPF: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting ospf6d ... 2018/08/27 09:33:38 errors: OSPF6: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting pbrd ... 2018/08/27 09:33:38 errors: PBR: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting pimd ... 2018/08/27 09:33:38 errors: PIM: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting ripd ... 2018/08/27 09:33:39 errors: RIP: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting ripngd ... 2018/08/27 09:33:39 errors: RIPNG: NS initialization failure 2(No such file or directory)
procd: /etc/rc.d/S60frr: frr.init: Starting watchfrr ... done.
watchfrr: watchfrr 5.0.1 watching [zebra babeld bgpd eigrpd isisd ldpd nhrpd ospfd ospf6d pbrd pimd ripd ripngd]
watchfrr: zebra state -> up : connect succeeded
watchfrr: ldpd state -> up : connect succeeded
watchfrr: pbrd state -> up : connect succeeded
watchfrr: eigrpd state -> up : connect succeeded
watchfrr: ripd state -> up : connect succeeded
watchfrr: babeld state -> up : connect succeeded
watchfrr: ospf6d state -> up : connect succeeded
watchfrr: ospfd state -> up : connect succeeded
watchfrr: ripngd state -> up : connect succeeded
watchfrr: bgpd state -> up : connect succeeded
watchfrr: isisd state -> up : connect succeeded
watchfrr: pimd state -> up : connect succeeded
watchfrr: nhrpd state -> up : connect succeeded

So it just seems to be a cosmetic thing.

It would still be nice to fix it anyway so that users don't see a warning/error during startup, although it has no relevance to them.

[pguibert6WIND]

if you can try https://github.com/FRRouting/frr/pull/2938, this may help.

[cfra]

Could we also get this in dev/6.0 ?