"lib,mlag : Defining MLAG Proto file" commit broke snap build - Githubissues

FRRouting / frr

The FRRouting Protocol Suite

https://frrouting.org/

Other

3.33k stars 1.25k forks source link

"lib,mlag : Defining MLAG Proto file" commit broke snap build #5453

Open mwinter-osr opened 4 years ago

mwinter-osr commented 4 years ago

Commit https://github.com/FRRouting/frr/commit/e05ab0b0c8ecdd76afe972572cff2c0f9cc14574 forces FRR Protobuf to use 'proto3' which is not available in a package on Ubuntu 16.04 (and potentially others)

  PROTOC_C mlag/mlag.pb-c.c
mlag/mlag.proto:10:10: Unrecognized syntax identifier "proto3".  This parser only recognizes "proto2".
Makefile:9677: recipe for target 'mlag/mlag.pb-c.c' failed

FRR Snap packages fail building since this commit (as the snap package includes protobuf and builds on Ubuntu 16.04)

donaldsharp commented 4 years ago

Install protobuf 3 compiler?

satheeshkarra commented 4 years ago

Other workaround is disable "PROTOBUF" is you don't need..?, (or) as Donald said Protobuf-3 need to be installed

mwinter-osr commented 4 years ago

Please suggest package which contains Protobuf-3 for Ubuntu 16.04. I can't find this version in the official repos. So this makes it either unsupported on Ubuntu 16.04 (and probably others) or maybe there is a way to change this to keep it compatible to the older Protobuf version?

"protobuf not needed" for a package is not an option. It should be supported.

satheeshkarra commented 4 years ago

protobuf-c-compiler, libprotobuf-c-dev

mwinter-osr commented 4 years ago

Installed, but not providing the protobof-3. They only support protobuf-2

# apt install protobuf-c-compiler libprotobuf-c-dev
Reading package lists... Done
Building dependency tree       
Reading state information... Done
libprotobuf-c-dev is already the newest version (1.2.1-1).
protobuf-c-compiler is already the newest version (1.2.1-1).
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.

satheeshkarra commented 4 years ago

can you please try this.. https://github.com/linkerd/linkerd/issues/1118

mwinter-osr commented 4 years ago

can you please try this.. linkerd/linkerd#1118

Won't work. This isn't a package. We need a supported package to be able to build packages.

satheeshkarra commented 4 years ago

you mean Un-isnatlling & re-installing(apt remove & apt install) not working..?

satheeshkarra commented 4 years ago

you mean Un-isnatlling & re-installing(apt remove & apt install) not working..?

satheeshkarra commented 4 years ago

you mean Un-isnatlling & re-installing(apt remove & apt install) not working..?

satheeshkarra commented 4 years ago

you mean Un-isnatlling & re-installing(apt remove & apt install) not working..?

mwinter-osr commented 4 years ago

Package is already at latest version - there is no newer version as a package and that version doesn't support protobuf-3

satheeshkarra commented 4 years ago

On Ubuntu 18.04 I am not seeing any issues.

mwinter-osr commented 4 years ago

We are still supporting CentOS 6, 7, Debian 8, 9, 10, Ubuntu 14.04, 16.04 and 18.04 (beside of some BSD) Can you please investigate to get your changes working with Protobuf v2 ?

satheeshkarra commented 4 years ago

Actually the Receiver in our case which is MLAGD is also using proto3 encoding & Decoding, if we change encoding to proto2 at FRR, functionality might not working as expected until MLAGD also changes to proto2.

Can I guard this using a new compilation flag" HAVE_PROTOBUF3"..?