search

FRRouting / frr

The FRRouting Protocol Suite
https://frrouting.org/
Other
3.34k stars 1.25k forks source link

Frrouting: LDP is not assigned labels to addresses 169.254.0.0/16 #7273

Open ne-vlezay80 opened 4 years ago

ne-vlezay80 commented 4 years ago

Describe the bug LDP daemon is not assigneng labels for link local ipv4 address.

(put "x" in "[ ]" if you already tried following) [ ] Did you check if this is a duplicate issue? [ *] Did you test it on the latest FRRouting/frr master branch?

Expected behavior Assigning labels from the address space.

Versions

Additional context The routing table: archlinux# show ip route

Codes: K - kernel route, C - connected, S - static, R - RIP,
       O - OSPF, I - IS-IS, B - BGP, E - EIGRP, N - NHRP,
       T - Table, v - VNC, V - VNC-Direct, A - Babel, D - SHARP,
       F - PBR, f - OpenFabric,
       > - selected route, * - FIB route, q - queued, r - rejected, b - backup
       t - trapped, o - offload failure
K>* 0.0.0.0/0 [0/0] via 198.18.50.1, ens3, 00:35:43
O   169.254.100.1/32 [110/0] is directly connected, lo, weight 1, 00:35:42
C>* 169.254.100.1/32 is directly connected, lo, 00:35:43
O>* 169.254.100.2/32 [110/10] via 169.254.101.2, tunnel0, weight 1, 00:35:22
O   169.254.101.0/30 [110/10] is directly connected, tunnel0, weight 1, 00:35:42
C>* 169.254.101.0/30 is directly connected, tunnel0, 00:35:43
O>* 169.254.150.0/30 [110/20] via 169.254.101.2, tunnel0, weight 1, 00:35:22
O>* 192.168.0.1/32 [110/10] via 169.254.101.2, tunnel0, label IPv4 Explicit Null, weight 1, 00:00:20
C>* 198.18.50.1/32 is directly connected, ens3, 00:35:43
donaldsharp commented 3 years ago

ldp works by sending a redistribute all command to zebra. Zebra then dumps the entirety of it's table into ldp. The problem is that we have guards in zebra that prevent the sending of link local routes. @rwestphal is it legal to put labels on link local addresses or is this a good limtation for ldp?