Open donaldsharp opened 3 years ago
PR #8409 fixes one part of it but there are more things left.
Instructions for people to test:
Compile FRR without ASAN (this is the default)
Add this patch to your topotest:
diff --git a/tests/topotests/lib/topotest.py b/tests/topotests/lib/topotest.py
index 104b21507..d68f46663 100644
--- a/tests/topotests/lib/topotest.py
+++ b/tests/topotests/lib/topotest.py
@@ -1512,7 +1512,10 @@ class Router(Node):
) + "/var/run/{}/snmpd.pid -x /etc/frr/agentx".format(self.routertype)
else:
binary = os.path.join(self.daemondir, daemon)
- cmdenv = "ASAN_OPTIONS=log_path={0}.asan".format(daemon)
+ if daemon == "ospfd":
+ cmdenv = "ASAN_OPTIONS=log_path={0}.asan valgrind --log-file=/tmp/valgrind/%p --leak-check=full ".format(daemon)
+ else:
+ cmdenv = "ASAN_OPTIONS=log_path={0}.asan".format(daemon)
cmdopt = "{} --log file:{}.log --log-level debug".format(
daemon_opts, daemon
)
Before running topotest create the valgrind output directory: mkdir /tmp/valgrind ; chmod 1777 /tmp/valgrind
Run the bfd-topo2
topology test
Read the /tmp/valgrind/*
files
@rgirada Pls check this once.