net-misc/frr: compilation failure

rzalamena commented 4 years ago

I tried to build net-misc/frr-7.1-r1 but it is failing in my Gentoo stable.

Compilation error message:

pimd/pim_register.c: In function ‘pim_register_join’:                                                                                                                                                                                          
pimd/pim_register.c:64:41: error: ‘TRUE’ undeclared (first use in this function)                                                                                                                                                               
   64 |  pim_vxlan_update_sg_reg_state(pim, up, TRUE /*reg_join*/);                                                                                                                                                                            
      |                                         ^~~~                                                                                                                                                                                           
pimd/pim_register.c:64:41: note: each undeclared identifier is reported only once for each function it appears in                                                                                                                              
pimd/pim_register.c: In function ‘pim_register_stop_recv’:                                                                                                                                                                                     
pimd/pim_register.c:151:4: error: ‘FALSE’ undeclared (first use in this function)                                                                                                                                                              
  151 |    FALSE /*reg_join*/);                                                                                                                                                                                                                
      |    ^~~~~

This problem was recently fixed in upstream (related frrouting/frr#6208 , frrouting/frr#6209). Basically json-c upstream removed some macro booleans and some code in FRR was expecting it, the FRR fix was to migrate all booleans to stdbool format but I think the PRs are scattered.

I'm not sure how to fix this: patch files, downgrade json-c or just wait for new FRR ebuild...

f0o commented 4 years ago

I guess this can be closed?

rzalamena commented 4 years ago

Yes, I think so. I don't think it is useful to spend energy on this unless someone wants to use it.

I think it is useful to have this documented so if someone stumbles in this error message the person has an idea what is going on. Other than that I don't want to spend time fixing this if nobody is using.

FRRouting / gentoo-overlay

net-misc/frr: compilation failure #59