ospf-topo1-vrf: show errors and reduce code

[rzalamena]

Use standardized code and fix assert messages to include errors.

Signed-off-by: Rafael Zalamena rzalamena@opensourcerouting.org

---

This PR is a response to this CI system run failure: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-4931/

In this PR: https://github.com/FRRouting/frr/pull/2875

Missing messages:

test_ospf_topo1_vrf test_ospf_kernel_route

AssertionError: OSPF IPv4 route mismatch in router "r1" assert False
E   AssertionError: OSPF IPv4 route mismatch in router "r1"
    assert False

test_ospf_topo1_vrf test_ospf_link_down_kernel_route

AssertionError: OSPF IPv4 route mismatch in router "r1" after link down assert False
E   AssertionError: OSPF IPv4 route mismatch in router "r1" after link down
    assert False

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-TOPOPR-333/

This is a comment from an EXPERIMENTAL automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Topotest Checkout: Successful

Topotests: Failed

Topotest master arm8: Successful Topotest master amd64: Successful Topotest 2.0 branch: Successful Topotest 4.0 branch: Successful Topotest 3.0 branch: Successful Topotest master arm7: Successful Topotest master i386: Successful Topotest 5.0 branch: Successful

Addresssanitizer: Failed

Addresssanitizer: Unknown Log URL: https://ci1.netdef.org/browse/FRR-TOPOPR-333/artifact/AD/TestExecutionLogs/ Addresssanitizer: Unknown Log URL: https://ci1.netdef.org/browse/FRR-TOPOPR-333/artifact/AD/AddressSanitizerError/ Topology Test Results are at https://ci1.netdef.org/browse/FRR-TOPOPR-AD-333/test

Topology Tests failed for Addresssanitizer see full log at https://ci1.netdef.org/browse/FRR-TOPOPR-333/artifact/AD/ErrorLog/log_topotests.txt

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-TOPOPR-334/

This is a comment from an EXPERIMENTAL automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

[pguibert6WIND]

before merging this, I would be curious to know why fabric daemon did make this regression. are you analysng the reason why fabricd does not work with that test, or are you just enhancing testing ?

[rzalamena]

@pguibert6WIND

why dont you copy paste the recent changes from ospf-topo1 into ospf-topo1-vrf ? for instance count=160 and not count=140

Makes sense.

before merging this, I would be curious to know why fabric daemon did make this regression. are you analysng the reason why fabricd does not work with that test, or are you just enhancing testing ?

I'm enhancing the test so I can see what the failure message is. At the moment we just know that it failed on these specific tests: test_ospf_kernel_route and test_ospf_kernel_route .

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-TOPOPR-335/

This is a comment from an EXPERIMENTAL automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.