search

FRRouting / topotests

Moved to frrouting/frr
22 stars 26 forks source link

Use directory per node, report cores stacks and memory on exit #91

Closed louberger closed 6 years ago

louberger commented 6 years ago

addresses #88 and #88

NetDEF-CI commented 6 years ago

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-TOPOPR-228/

This is a comment from an EXPERIMENTAL automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

NetDEF-CI commented 6 years ago

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-TOPOPR-229/

This is a comment from an EXPERIMENTAL automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

mwinter-osr commented 6 years ago

The per-router directory seems to work, but on the core-dumps, I get 2 copies. (Running ./test_bgp_l3vpn_to_bgp_vrf.py with frr @ git e8f9540)

2018-05-09 19:09:39,440 INFO: ce2: stopping bgpd
2018-05-09 19:09:39,443 INFO: ce2: stopping zebra
2018-05-09 19:09:39,450 INFO: ce1: stopping bgpd
2018-05-09 19:09:39,455 INFO: ce1: stopping zebra
2018-05-09 19:09:39,456 INFO: stopping "sw1"
2018-05-09 19:09:39,456 INFO: stopping "sw0"
2018-05-09 19:09:39,456 INFO: stopping "sw2"

r4: bgpd crashed. Core file found - Backtrace follows:
[New LWP 11186]
[New LWP 11191]
[New LWP 11190]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f7de6d5d428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7f7de7e61880 (LWP 11186))]
#0  0x00007f7de6d5d428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f7de6d5f02a in __GI_abort () at abort.c:89
#2  0x00007f7de7a7ca8a in core_handler (signo=11, siginfo=0x7ffd440af170, context=0x7ffd440af040) at lib/sigevent.c:249
#3  <signal handler called>
#4  0x0000557cb19ee1f6 in sendmsg_zebra_rnh (bnc=0x557cb518a150, command=24) at bgp_nht.c:570
#5  0x0000557cb19ee3c1 in unregister_zebra_rnh (is_bgp_import_route=<optimized out>, bnc=0x557cb518a150) at bgp_nht.c:641
#6  bgp_unlink_nexthop_check (bnc=0x557cb518a150) at bgp_nht.c:97
#7  0x0000557cb19ee4f0 in bgp_unlink_nexthop_check (bnc=<optimized out>) at bgp_nht.c:116
#8  bgp_unlink_nexthop (path=path@entry=0x557cb5193890) at bgp_nht.c:115
#9  0x0000557cb199ffc0 in bgp_info_free (binfo=0x557cb5193890) at bgp_route.c:211
#10 bgp_info_unlock (binfo=0x557cb5193890) at bgp_route.c:236
#11 0x0000557cb19a00c9 in bgp_info_reap (rn=rn@entry=0x557cb51937c0, ri=0x557cb5193890) at bgp_route.c:280
#12 0x0000557cb19a01a6 in bgp_clear_route_table (peer=peer@entry=0x557cb2a22820, afi=afi@entry=AFI_IP, safi=safi@entry=SAFI_UNICAST, table=<optimized out>, table@entry=0x0) at bgp_route.c:3883
#13 0x0000557cb19a53bb in bgp_clear_route (peer=peer@entry=0x557cb2a22820, afi=afi@entry=AFI_IP, safi=safi@entry=SAFI_UNICAST) at bgp_route.c:3931
#14 0x0000557cb19a5560 in bgp_clear_route_all (peer=peer@entry=0x557cb2a22820) at bgp_route.c:3949
#15 0x0000557cb1992aa8 in bgp_fsm_change_status (peer=peer@entry=0x557cb2a22820, status=status@entry=8) at bgp_fsm.c:925
#16 0x0000557cb198500d in peer_delete (peer=0x557cb2a22820) at bgpd.c:2187
#17 0x0000557cb1989ca9 in bgp_delete (bgp=0x557cb2a215a0) at bgpd.c:3304
#18 0x0000557cb197cfb8 in bgp_exit (status=0) at bgp_main.c:184
#19 sigint () at bgp_main.c:150
#20 0x00007f7de7a7cb28 in quagga_sigevent_process () at lib/sigevent.c:103
#21 0x00007f7de7a8902d in thread_fetch (m=m@entry=0x557cb22e95e0, fetch=fetch@entry=0x7ffd440af9e0) at lib/thread.c:1359
#22 0x00007f7de7a64ef3 in frr_run (master=0x557cb22e95e0) at lib/libfrr.c:878
#23 0x0000557cb197ade2 in main (argc=1, argv=0x7ffd440afc38) at bgp_main.c:416
2018-05-09 19:09:39,910 INFO: stopping "sw1"
2018-05-09 19:09:39,910 INFO: stopping "sw0"
2018-05-09 19:09:39,910 INFO: stopping "sw2"

r4: bgpd crashed. Core file found - Backtrace follows:
[New LWP 11186]
[New LWP 11191]
[New LWP 11190]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/bgpd'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007f7de6d5d428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
[Current thread is 1 (Thread 0x7f7de7e61880 (LWP 11186))]
#0  0x00007f7de6d5d428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1  0x00007f7de6d5f02a in __GI_abort () at abort.c:89
#2  0x00007f7de7a7ca8a in core_handler (signo=11, siginfo=0x7ffd440af170, context=0x7ffd440af040) at lib/sigevent.c:249
#3  <signal handler called>
#4  0x0000557cb19ee1f6 in sendmsg_zebra_rnh (bnc=0x557cb518a150, command=24) at bgp_nht.c:570
#5  0x0000557cb19ee3c1 in unregister_zebra_rnh (is_bgp_import_route=<optimized out>, bnc=0x557cb518a150) at bgp_nht.c:641
#6  bgp_unlink_nexthop_check (bnc=0x557cb518a150) at bgp_nht.c:97
#7  0x0000557cb19ee4f0 in bgp_unlink_nexthop_check (bnc=<optimized out>) at bgp_nht.c:116
#8  bgp_unlink_nexthop (path=path@entry=0x557cb5193890) at bgp_nht.c:115
#9  0x0000557cb199ffc0 in bgp_info_free (binfo=0x557cb5193890) at bgp_route.c:211
#10 bgp_info_unlock (binfo=0x557cb5193890) at bgp_route.c:236
#11 0x0000557cb19a00c9 in bgp_info_reap (rn=rn@entry=0x557cb51937c0, ri=0x557cb5193890) at bgp_route.c:280
#12 0x0000557cb19a01a6 in bgp_clear_route_table (peer=peer@entry=0x557cb2a22820, afi=afi@entry=AFI_IP, safi=safi@entry=SAFI_UNICAST, table=<optimized out>, table@entry=0x0) at bgp_route.c:3883
#13 0x0000557cb19a53bb in bgp_clear_route (peer=peer@entry=0x557cb2a22820, afi=afi@entry=AFI_IP, safi=safi@entry=SAFI_UNICAST) at bgp_route.c:3931
#14 0x0000557cb19a5560 in bgp_clear_route_all (peer=peer@entry=0x557cb2a22820) at bgp_route.c:3949
#15 0x0000557cb1992aa8 in bgp_fsm_change_status (peer=peer@entry=0x557cb2a22820, status=status@entry=8) at bgp_fsm.c:925
#16 0x0000557cb198500d in peer_delete (peer=0x557cb2a22820) at bgpd.c:2187
#17 0x0000557cb1989ca9 in bgp_delete (bgp=0x557cb2a215a0) at bgpd.c:3304
#18 0x0000557cb197cfb8 in bgp_exit (status=0) at bgp_main.c:184
#19 sigint () at bgp_main.c:150
#20 0x00007f7de7a7cb28 in quagga_sigevent_process () at lib/sigevent.c:103
#21 0x00007f7de7a8902d in thread_fetch (m=m@entry=0x557cb22e95e0, fetch=fetch@entry=0x7ffd440af9e0) at lib/thread.c:1359
#22 0x00007f7de7a64ef3 in frr_run (master=0x557cb22e95e0) at lib/libfrr.c:878
#23 0x0000557cb197ade2 in main (argc=1, argv=0x7ffd440afc38) at bgp_main.c:416
NetDEF-CI commented 6 years ago

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-TOPOPR-231/

This is a comment from an EXPERIMENTAL automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

mwinter-osr commented 6 years ago

Looks good to me now.

Probably needs at a later date (when all crashes are fixed) a further commit with an extra test on each of the test suites to check for the core and mark it as a failure.