Open MadSandwich opened 1 year ago
@FRSgit could you please take a look on it? Unfortunately, I can't share the repo. If you need more details or something, let me know. Thanks for help in advance.
Hey @MadSandwich!
Sure, sorry for the late response.
I'll need a bit more details here:
cypress.config
configuration file?Hi @FRSgit ! Sure,
export default defineConfig({
e2e: {
baseUrl: ENVIRONMENT.baseUrl,
specPattern: 'cypress/e2e/**/*.feature',
experimentalRunAllSpecs: true,
chromeWebSecurity: false,
reporter: require.resolve('@badeball/cypress-cucumber-preprocessor/pretty-reporter'),
async setupNodeEvents(on, config) {
initPlugin(on, config)
await preprocessor.addCucumberPreprocessorPlugin(on, config)
on(
'file:preprocessor',
createBundler({
plugins: [createEsbuildPlugin.default(config)],
})
)
on('task', {
resolvePath(...args) {
return path.resolve(args.toString())
},
})
allureWriter(on, config)
return config
},
env: {
env: ENVIRONMENT,
pluginVisualRegressionImagesDir: './baseline/',
//Cucumber
filterSpecs: true,
omitFiltered: true,
//Reporters
// Cucumber reporter configurations
messagesEnabled: true,
messagesOutput: './report_results/cucumber-messages.json',
jsonEnabled: true,
jsonOutput: './report_results/cucumber-report.json',
htmlEnabled: true,
htmlOutput: './report_results/cucumber-report.html',
prettyEnabled: true,
// Allure reporter configurations
allure: true,
allureReuseAfterSpec: true,
allureResultsPath: './report_results/allure-results',
allureLogCypress: true,
allureLogGherkin: true,
},
},
viewportWidth: 1920,
viewportHeight: 1080,
video: false,
includeShadowDom: true,
retries: { runMode: 2, openMode: 0 },
trashAssetsBeforeRuns: true,
experimentalMemoryManagement: true,
})
@VitaliLebedzeu / @MadSandwich
Same as you, I'm also using @badeball/cypress-cucumber-preprocessor
and was also having the same problem. The images were always placed inside cypress/screenshots/
folder.
Looking at your cypress.config, you have the same "problem" I had. Try changing the order of
initPlugin(on, config)
await preprocessor.addCucumberPreprocessorPlugin(on, config)
to
await preprocessor.addCucumberPreprocessorPlugin(on, config)
initPlugin(on, config)
This partially solved the problem on my installation. But I can't use the images scaled to the viewport size...
The problem exists because of a cypress limitation, where only a single event handler can exist for each type of event. Because of that, there are conflicts between the current plugin and @badeball/cypress-cucumber-preprocessor
.
So, this problem is not a bug
on the @frsource/cypress-plugin-visual-regression-diff
plugin but, instead, is a result of the cypress limitation.
See https://github.com/badeball/cypress-cucumber-preprocessor/blob/master/docs/event-handlers.md for a clear explanation.
@kuldea-paulo thanks a lot. It works now for me. About "can't use the images scaled to the viewport size..." try to use cypress-on-fix . It helps to us with similar problems.
@VitaliLebedzeu thank you for the tip. I will definitely try it!!
Unfortunately, it doesn't work as I need. The problem is that plugin puts all snapshots (baseline and diffs) in one place determined the "imagesPath" variable and duplicate this information in the "cypress/screenshots" dir. Also, I can't determine path for diffs separately.
Describe the Bug
With default settings only, screenshots are saved to:![image](https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/assets/57759145/38495e71-7b3c-4ef4-8b7b-25e150ca4558)
With property -![image](https://github.com/FRSOURCE/cypress-plugin-visual-regression-diff/assets/57759145/901a5bc5-f1d9-46da-81aa-57430dbc380e)
imagesPath: './'
Steps to reproduce
Package.json
Was trying to run via cypress open and cypress run, in both cases I have issues with setting up a directory.
Expected behavior
Directory path set up with 'imagesDir' or 'imagesPath' should be interpreted in the right way.
Additional context
No response
Package version
latest
Device
PC
OS and version
Windows 11
Browser and version
Chrome (latest)
Node version
Node 21
I can work on it by myself
Code of Conduct