Adding LessonCard as part of implementing Page 2 (Lessons)

FRUK-Simulator / Simulator

First Robotics UK Simulator

https://sim.morethanrobots.uk/

MIT License

5 stars 17 forks source link

Adding LessonCard as part of implementing Page 2 (Lessons) #288

Closed yono10 closed 5 months ago

yono10 commented 5 months ago

Changes:

Implement LessonCard component, and add a use case to implement the Lessons page further.
Update the Components README accordingly.

Notes:

LessonCard component is currently missing only one more thing: the counter (for number of challenges).
Lesson Page is now only missing the InformationCard for "Guidance and resources" as the 6th card in the grid.

Screenshots

On ASUS Zenbook:

On iPad Pro (landscape):

On iPad Pro (portrait):

owen26 commented 5 months ago

would be nicer here to have button always align to the bottom of the block (achieved by having a transparent div between description and button grow to fill the gap)

owen26 commented 5 months ago

I think overall it's looking great and already handled responsiveness pretty well. Some minor details on edging cases I can might drop some extra comments but generally speaking I'm perfectly happy to merge it as it is.

yono10 commented 5 months ago

approved, feel free to either addrssing comment or just merge

Per IB message, let's address is separately afterwards. Thanks for reviewing, some good points 👍