search

FRiCKLE / ngx_postgres

upstream module that allows nginx to communicate directly with PostgreSQL database.
http://labs.frickle.com/nginx_ngx_postgres/
BSD 2-Clause "Simplified" License
545 stars 122 forks source link

Make ngx_postgres possible to build as dynamic module #54

Open cryptofuture opened 7 years ago

cryptofuture commented 7 years ago

Tested in production. I also updated version checks.

cryptofuture commented 7 years ago

PostgreSQL 9.2 released more then 4 years ago! I didn't seen questions for older then 9.4 version for a year on pgsql-admin. We have check per 9.1 and thats even an overkill. Longer check list makes config file harder to understand. Original config was made 6 years ago, many things changed in the world since then! There no any logical reason to support check per 8.0 postgresql version btw, pls check fix build with 1.11.6 request, I changed that line.

agentzh commented 7 years ago

@cryptofuture Pull requests should be atomic and minimized. It's not good practice to include unrelated changes. If you think we should drop version checks against older Pg, then it deserves a separate dedicated pull request I'm afraid.

jmealo commented 6 years ago

@cryptofuture: thank you for your work! Do you have time to split this PR into two separate ones as requested by @agentzh?

kvishnivetsky commented 3 years ago

I'm interested in this feature. Is this PR still alive?