search

FRosner / cluster-broccoli

Self service for Nomad based on templates.
Apache License 2.0
60 stars 22 forks source link

Fix/remove Docker tests #369

Open sohaibiftikhar opened 6 years ago

sohaibiftikhar commented 6 years ago

The Docker tests currently require docker hub credentials and any contribution made from a fork fails the test making the CI not very reliable unless you look at the logs. Maybe we should push to docker hub only when a request is merged to master.

FRosner commented 6 years ago

Yes the Docker push should only be executed if the branch is NOT a pull request coming from external. I think Travis injects an environment variable to determine whether it's an internal branch or an external PR.

We cannot push only on master as we make use of the tags from branches for test deployments as well.

Would you like to make that change, @sohaibiftikhar?