PyDDQ Check.run prints console report to stdout by default

FRosner / drunken-data-quality

Spark package for checking data quality

Apache License 2.0

222 stars 69 forks source link

PyDDQ Check.run prints console report to stdout by default #108

Closed Gerrrr closed 8 years ago

Gerrrr commented 8 years ago

Problem

Running the examples from the README.md would not work in iPython.

Solution

With this PR, if the reporter is not specified in the Check.run call, ConsoleReporter is used by default. Its output is written into ByteArrayOutputStream and then printed. Since print function is used, it will output correctly to the overwritten sys.stdout's. For example, it will work in Jupyter with its IPython.kernel.zmq.iostream.OutStream used as stdout.

codecov-io commented 8 years ago

Current coverage is 100% (diff: 100%)

Merging #108 into master will not change coverage

@@           master   #108   diff @@
====================================
  Files          24     24          
  Lines         437    437          
  Methods       421    421          
  Messages        0      0          
  Branches       16     16          
====================================
  Hits          437    437          
  Misses          0      0          
  Partials        0      0

Powered by Codecov. Last update c89d664...52a7933

FRosner commented 8 years ago

LGTM @Gerrrr. Did you test it? Can you put a screenshot?

Gerrrr commented 8 years ago

PyDDQ in Jupyter: https://yadi.sk/i/URVVvQlVuExRi For the terminal and Zeppelin nothing was changed.