Open Gerrrr opened 7 years ago
While working on #133 I checked Check.hasNumRows type signature and was curious why it is expected: Column => Column. Wouldn't it be simpler to use Long => Boolean or something like that? Also, it'd be possible to use df.count() instead of https://github.com/FRosner/drunken-data-quality/blob/master/src/main/scala/de/frosner/ddq/constraints/NumberOfRowsConstraint.scala#L9.
Check.hasNumRows
expected: Column => Column
Long => Boolean
df.count()
While working on #133 I checked
Check.hasNumRowstype signature and was curious why it isexpected: Column => Column. Wouldn't it be simpler to useLong => Booleanor something like that? Also, it'd be possible to usedf.count()instead of https://github.com/FRosner/drunken-data-quality/blob/master/src/main/scala/de/frosner/ddq/constraints/NumberOfRowsConstraint.scala#L9.