FRosner / drunken-data-quality

Spark package for checking data quality
Apache License 2.0
222 stars 69 forks source link

Logo #94

Closed FRosner closed 8 years ago

FRosner commented 8 years ago

Probosals

image

image

image

image

image

FRosner commented 8 years ago

I like the guy with the top hat and the monocle most. What do you think, @Gerrrr? It reflects quality + drunken pretty good. Only data is missing.

Gerrrr commented 8 years ago

I like the owl and the guy with the hat and the monocle. Unfortunately, the problem with the latter is that he is overused everywhere.

FRosner commented 8 years ago

He is - but not in open source projects, is he? But I get your point.

Kuva commented 8 years ago

The first option to figure out what you actually want. option 1

FRosner commented 8 years ago

Thank you @Kuva. I'd love to have a nice logo related to data and quality, possibly also something with drinks (because the project is called drunken data quality :D).

So if we took the guy you prepared, made it a bit more interesting (colors, etc.) and maybe somehow add data or drunken, I'd be happy I guess. He already looks like good quality 👍

But we can also have a quick chat in person if you'd like :)

Kuva commented 8 years ago

Option 2.2. Got lots of feedback on the original Option 2 from Aleks & implemented it. ddq v2 2

FRosner commented 8 years ago

Wow that's very different from the first one!

I like the symbol, the font is a bit boring but it might not be needed anyway. Is there a special meaning behind that symbol? Colors, shapes? The small triangle?

Thanks again for your help @Kuva

Kuva commented 8 years ago

The triangles are data constrains, green – successfully passed, orange – failed, grey – errors. Lines symbolise structure of a table. Overall it's a shape of Q that's why it has that small triangular, it also refers to drunken as having a part that doesn't fit to the structure.

I haven't decided on a font yet. I'm not sure how it should look.

FRosner commented 8 years ago

Cool. Maybe we should change the colors a bit, now that I know the details. On the console reporter green is success, red is failure and yellow is error. But that looks very much like a traffic light. So I might take your colors instead. I'll think about it.

I don't understand the part with the lines but I really love the triangular constraints. Should've called the project triangular data quality 😄

About the font - do we need font anyway? For me it's ok to start with a logo and we can add text if we need it. What do you think?

Kuva commented 8 years ago

I'll work on the colours more as well to find the right combination. It takes a while of messing with different shades to find the best combination.

I think it's better with the font but the sign can be used without it as well. I'll make some variations so you can see for yourself.

Kuva commented 8 years ago

Version 3 ddq logo v3-07 ddq logo v3-09

FRosner commented 8 years ago

Amazing @Kuva! However, if we want to keep the notion of violation = red/orange and error = the other color, the purple might be a problem. It needs to look nice both on black and white backgrounds because people have black or white terminal backgrounds. I like the way it looks now a lot of I also love consistency. So what about making the yellow/orange in the latest version a bit more redish and replacing the purple color with something lighter (I think grey is not that ugly to be honest but we could also stick to the green yellow red that I am currently using.

I'm using the ascii terminal color codes (https://en.wikipedia.org/wiki/ANSI_escape_code). I use red for failures, I am using green for success and I have been using yellow for failure. However, yellow looks probably bad on white background that's why I thought about replacing it but I don't really know with what.

Hope this gives some more feedback / insight. But we don't need to necessarily stick to the colors, esp as they might change in the future and also depend on the reporter (markdown e.g. does not even have colors).

Anyway I like it a lot, the solid one even a bit more :)

What does @Gerrrr say?

image

Kuva commented 8 years ago

@FRosner, thank you for you feedback! I didn't know that the logo should work on both white & black. Made some adjustments.

ddq logo v3 2
FRosner commented 8 years ago

No sorry. Not the logo has to work (although it's nice if it does, but the colors in the reporter have to. I can show you how it looks.

Kuva commented 8 years ago

@FRosner The colours of the logo doesn't have to be the same ones as you use in the reporter. It's good if you can but it's not obligatory.

FRosner commented 8 years ago

Looking at your last proposals @Kuva, I like the last row most. And it actually works both on black and white backgrounds 👍

Also it is not so intrusive and looks very professional.

FRosner commented 8 years ago

So are we going to go for the last one, @Kuva? How do you want to share it? Do you want to upload it at openclipart?

Kuva commented 8 years ago

Sure, let's settle on the last logo. What format do you need: png or svg? If png, then I need to know the size. Openclipart doesn't look like a place to upload a logo.

FRosner commented 8 years ago

You're the expert @Kuva. Tell me where you want to put it. I'd put it somewhere where I can download it in different sizes. I'd like to store it as SVG, so we can resize it later.

But I guess we can at least put it in git. Do you want to create a pull request or do you want to send it to me via mail / upload it to whatever site you'd like and I do it.

Thanks again!

FRosner commented 8 years ago

https://github.com/FRosner/drunken-data-quality/blob/master/logo/DDQ.svg