search

FSGModding / FSG_Mod_Assistant

Farming Simulator 22 Mod Manager.
https://fsgmodding.github.io/FSG_Mod_Assistant/
ISC License
71 stars 11 forks source link

[BUG] #164

Closed Antwalsh90 closed 11 months ago

Antwalsh90 commented 11 months ago

Is there an existing issue for this?

Current Behavior

I'm sorry if this is a me problem. I can't explain the problem but I copied the log;

2023-08-11 14:56:02 | INFO | ModAssist Logger : 3.0.0 2023-08-11 14:56:02 | INFO | - Node.js Version : 18.15.0 2023-08-11 14:56:02 | INFO | - Electron Version : 25.3.2 2023-08-11 14:56:02 | INFO | - Chrome Version : 114.0.5735.248 2023-08-11 14:56:02 | INFO | translate-lib >> Starting i18n Library :: en 2023-08-11 14:56:02 | INFO | auto-update >> Checking for update 2023-08-11 14:56:04 | INFO | modhub-cache >> Got modHubDataCombo.json: 200 2023-08-11 14:56:04 | INFO | auto-update >> Update for version 3.0.0 is not available (latest version: 3.0.0, downgrade is disallowed). 2023-08-11 14:56:07 | DANGER | game-settings >> Could not read game settings TypeError: Cannot read properties of undefined (reading 'modsDirectoryOverride') 2023-08-11 14:56:07 | INFO | New version detected, show changelog 2023-08-11 14:57:42 | DANGER | game-settings >> Could not read game settings TypeError: Cannot read properties of undefined (reading 'modsDirectoryOverride')

Expected Behavior

No response

Steps To Reproduce

No response

Environment

2023-08-11 14:56:02 |    INFO | ModAssist Logger    : 3.0.0
2023-08-11 14:56:02 |    INFO |  - Node.js Version  : 18.15.0
2023-08-11 14:56:02 |    INFO |  - Electron Version : 25.3.2
2023-08-11 14:56:02 |    INFO |  - Chrome Version   : 114.0.5735.248
2023-08-11 14:56:02 |    INFO | translate-lib >> Starting i18n Library :: en
2023-08-11 14:56:02 |    INFO | auto-update >> Checking for update
2023-08-11 14:56:04 |    INFO | modhub-cache >> Got modHubDataCombo.json: 200
2023-08-11 14:56:04 |    INFO | auto-update >> Update for version 3.0.0 is not available (latest version: 3.0.0, downgrade is disallowed).
2023-08-11 14:56:07 |  DANGER | game-settings >> Could not read game settings TypeError: Cannot read properties of undefined (reading 'modsDirectoryOverride')
2023-08-11 14:56:07 |    INFO | New version detected, show changelog
2023-08-11 14:57:42 |  DANGER | game-settings >> Could not read game settings TypeError: Cannot read properties of undefined (reading 'modsDirectoryOverride')

Anything else?

No response

jtsage commented 11 months ago

So, this is one of two issues - either it can't find your gameSettings.xml file, which seems unlikely, because I think it catches that error, or the file is no longer formed correctly. If you wanted to send me that file, I can add some traps to catch this behavior, but the "Easy" way to fix this is to delete gameSettings.xml and then (directly) start the game - this will "reset" the file to the defaults and everything should be golden.

That file is in Documents -> My Games -> Farming Simulator 2022

Antwalsh90 commented 11 months ago

I'll go the easy way lol. Any idea what caused it? So I can avoid doing it again

jtsage commented 11 months ago

My guess is it is some sort of race condition where MA and the game are trying to write to that file at the exact same time, and things go screwy. I'd assume it is always safer to not mark a new mod collection as active with the game open, but I've not been able to recreate it in any way, so that's just a guess

Antwalsh90 commented 11 months ago

Your fix worked but I didnt change the the save game whilst open. Unless FS updated, there has been no change to anything I can think of my end.

Thanks for helping!