[VERSION TRACK] v3.4.1 Known Issues & Bugs

[jtsage]

Known Bugs - v3.4.1

This issue is an umbrella issue to keep track of bugs in the current version. You can reply directly here, but opening a new issue would make life easier for us.

Issue List (included in 3.4.1)

• [x] (3.4.1) Misspelling of 2 new fill types from straw harvest (or variants) 954c80174d3c9cb6687f6cef8295b2e9f684d079
• [x] (3.4.1) Dumb logic typo for base game placeables (they all have the "parent file" warning background) 72f1325edd55c42336d4d76d66243c5d7f03893d
• [x] (3.4.1) Game running indicator not hiding as expected. 0d06dc5c9632db7530cb49c3fae3c17e032c78bf
• [x] (3.4.1) Chart Units missing on mod detail pages ab26a44e1d71990bc363908b1804d71824f99103
• [x] (3.4.1) Unusable mods not visually different in mod list f1142e69a011449b199a9b9aee13eb48423c2097
• [x] (3.4.1) Documentation was very, very outdated. ce3383290acb48c3e9d996e950d91bc055134698, d61773d9a1120ef81e03d33407bb26ae15d9aba5, 4d5daab5a5d744c5d2cc97868bee0685ba851fa6, 855b55dcd321f0382a712d87d158828a47efdb30

Issue List (included in 3.5.0-RC1)

• [x] (3.4.91) Add logic trap to remove /x86/ from game path on base game browser. #211 c663d5296a0b477d7c33c90a98dfc4f5261daae3
• [x] (3.4.91) Download display was wonky, mis-placed text, and the speed calculation failed at 1,000Mb. Also allow https:// in server URL's. 91b1d5f42f1245a334b17bdaca9cde4cfaaa42e4
• [x] (3.4.91) Visual indication needed on mini-mode when game is running. 7850107a44dabd7b8a10d789e607ab16de988957
• [x] (3.4.91) Add option to drag-and-drop a CSV collection export to the main window to compare it to current collections. Uses the same visual interface as the savegame compare tool. #208 7850107a44dabd7b8a10d789e607ab16de988957, 278fcc2d03cac68144870688a9397eeb7c4ba5c1
• [x] (3.4.91) Deep link of attacher joints in mod detail display broken 4ecd658d32931f898975fb8aeaa70921fe04f91a
• [x] (3.4.91) Button list for collections was getting long, prefer icon for savegame checker. ab1a8f3e88277577bd689fee7ca8e015040da1eb
• [x] (3.4.91) Preferences window is clunky - #212 0a5fbcc6b713b4ca26f2ff8a266f9a7dd1728be6, f02cd6e1d44ef9d1c8834582f585100e76ba1de8
• [x] (3.4.91) Collection Management in separate window is clunky - #213 0a5c3387224cc42419fb94d38888ac7bcf808eeb
• [x] (3.4.91) Code duplication in preload files, some can probably be shared. fd045036185a7d075f3f0537e9f2981df1ec2a2c
• [x] (3.4.91) Disabling older FS does not disable XML file checking #214 0c18f1312cbab5136279ada40bfe5be842ceabd4
• [x] (3.4.91) Game Polling (status bubble) should be optional. 1b630fa0de123e699df4d4b71c67af1ba5ca6a4f
• [x] (3.4.91) Collection details/notes page should visually resemble settings page. 193cc6dc3f392c46c5f1ae40595fb9094a1ca1b6

Issue List (included in 3.5.0-RC2)

• [x] Missed some log spam for game polling 15760ebd63aff25dbb97f9d9eb9693433eb8d2da
• [x] Checkbox on preferences / collections details is unclear, use a custom option diff 3bf6245777fff8e255059c7e462946bf16bf5fee
• [x] Visual overlap on gamelog screen #215 7eff21642c5f95c6833f75b7af92419e69c4c46a
• [x] Right click to copy/move/delete all selected would be nice ae205dcf5126f6f96e26ee51fedc62a7a19e463c
• [x] Not happy with the spacing / alignment of side buttons since change to configurable font-size f7523ac2a2d818bd3d679142ca8af01bd68115a6
• [x] Right click on a savegame had an icon code, not text. fix in l10n files. f23e09e8d536b62c1d54385ef80b23cccf7dd671

Issue List (included in 3.5.0-RC4)

• [x] Add GitHub Cat to button 4ba2740fd0d7a2e4c1e3df7fa74ae7d3844aba3e
• [x] Add Icons to right click menus 228c6d607961159d011cbeddafa0805ff885c91c
• [x] Hide Crop Calender JSON display when not applicable, turn into a copy-to-clipboard button otherwise. fa6a3bb3ef9293514149cf6aefe9208600b183c5, d5a7a70a48f0ed9cd5c145d683136c30bb89a1ec
• [x] Erase search box icon is off-center when font-size is not default. b3be9c1e81db9083cbdc7af4f618350a9cedfa0f
• [x] Open log file in explorer button not working a0a7d0e9cc037cd73cce231be6fe83f036bd71a7
• [x] FSG Bot integration (server status) would be pretty spiffy. e2dee3aaa0c52522b9ce443a7df9cf5c38dc1e16, 39eca690958f57e5b275bf45d1f3f1ec3cc319d8 howto
• [x] Need light variant (black) context menu icons as well. 0bcca1558e46daf43d86e3b514f7f457d467f15c, 2e4c05db35ff50a5fb569e41fe78bdef451520bd
• [x] Support for "Through the Years" mod - display the vehicle year in the details, if it is known. 29262f26a9ebe287d41d2f51c548dcca3e04836c

Issue List -- Included in 3.5.0-RC6, most in #218

• [x] Context menus follow the system theme, not the MA theme - this is probably wrong. 44823e21334f08ceb96d214d08990b0e85bdaf5b
• [x] A first-time setup wizard sure would be cool
• [x] The move/copy/delete/import windows shouldn't be separate windows, move them where they belong
• [x] Updates/changes got unwieldy again, refactor main file for readability and organization
• [x] Add season temperature detection for maps
• [x] Many visual changes to use inset-box model from preferences pane
• [x] CTRL+Space shortcut works in mini window now
• [x] drag-and-drop should not fire when file operation or preferences change is in progress
• [x] New tag filtering system using "advanced" radio buttons - I think it makes more sense as to what is happening
• [x] Add a "compare all" button to base game sub categories (e.g. "Large Tractors")
• [x] Try and plug a memory leak in the icon converter / generator
• [x] Share savegame compare results with the main window for as long as the savegame compare window remains open.

Issue List - Included in 3.5.0-RC7

• [x] Fix basegame graphs again
• [x] Catch modlook fail from missing folder/file
• [x] Make depends / required by submenus useful
• [x] automate HTML testing
• [x] Add icons to tray menu
• [x] Show dropdown when collection has multiple maps
• [x] Detect malicious mods (LUA that nukes your mods, saves and settings)

Special Note: there is no way I didn't break a few things on this RC, at least 1 or 2 more are going to be forthcoming before 3.5.0-RELEASE.

Progress

• [x] BugFix 3.4.1 Released : v3.4.1
• [x] 3.5.0-RC1 Released : v3.5.0-RC1
• [x] 3.5.0-RC2 Released : v3.5.0-RC2
• [x] 3.5.0-RC3 Released : v3.5.0-RC3
• [x] 3.5.0-RC4 Released : v3.5.0-RC4
• [x] 3.5.0-RC5 Released : v3.5.0-RC5
• [x] 3.5.0-RC6 Released : v3.5.0-RC6
• [x] 3.5.0-RC7 Released : v3.5.0-RC7

[vitalii2011]

This https://discord.com/channels/949619926463840327/1009879187429003377 is very frustrating.

[jtsage]

working on it right now. it'll be in the next update

[jtsage]

I just pushed the changes for the malware detector - there are probably other false positives out there, but I did check it against the entire 'gameplay' category on modhub, along with the popular script mods that I use. Please use issue #220 to report any others. If you want a safe file to test with, see here for my test mod, it has the offending code in a LUA file that is neither loaded nor able to actually run.

[vitalii2011]

Users may have problems with 3.5.0-RC7!

[vitalii2011]

When "I do not trust it, delete it right now" are archives with mods deleted not to the Recycle Bin/bypassing the Recycle Bin?

[jtsage]

When "I do not trust it, delete it right now" are archives with mods deleted not to the Recycle Bin/bypassing the Recycle Bin?

that's correct - they are removed from disk directly, it bypasses the recycle bin. In this case, I could send it to the recycle bin - keep in mind, this is detecting mods with funky scripting (there were a whole bunch released in the last few days on some sites) - it is not, nor is intended to be a system wide malware scan - there are plenty of options for that already. This is only looking for mods that may maliciously alter your farm sim installation only.

[vitalii2011]

At the first launch, the color of the text did not change when hovering the cursor (the next time it changed):

https://github.com/FSGModding/FSG_Mod_Assistant/assets/41552153/396d0bfb-8acb-45d8-be9c-32069032be0e

it would be better if the arrow became a “pointing finger” - not everyone will be able to see the change in text color and understand that when clicked, an action from the text will occur.

[jtsage]

Oh, and some additional information on the rest of the buttons - the first one you mentioned does indeed delete the mod.

The second "I want to investigate this" adds it to an ignore list by hash and folder hash - if you move or copy the file to another collection, the warning will re-display for that copy of the mod. Also, that ignore flag is not saved, so the next time you start Mod Assitant, the warning will show again.

Finally the "I'm sure I trust this..." (last button) adds it to a saved list in your preferences, by name only - it will not show the "malware" tag, and it will not ask you about that mod ever again.

[jtsage]

At the first launch, the color of the text did not change when hovering the cursor (the next time it changed):

it would be better if the arrow became a “pointing finger” - not everyone will be able to see the change in text color and understand that when clicked, an action from the text will occur.

Got it - when I ran the RC build I noticed some odd behavior as well - it looked like the dialog was getting hung up in or under the changelog of the splash screen - I'll look at the timing of events on those. And i'll look at changing the pointer type as well.

[vitalii2011]

For some reason, MA didn’t like FS19_GlobalCompany. And deleted (due to my carelessness) VehicleInspector VehicleInspector.zip

[jtsage]

whoops. I should have checked vehicleinspector - I forget what his other massive overlay one was called, but I bet that does it too. And for some reason it never occurred to me to run it against my copy of 19 mods - I bet there's a fair few in there too. Thanks, I'll get them added prior to the next release

[vitalii2011]

That's why there was a question about the reason for deleting bypassing the Recycle Bin. Someone may delete something that they edited for a long time and/or cannot restore.

[jtsage]

That's why there was a question about the reason for deleting bypassing the Recycle Bin. Someone may delete something that they edited for a long time and/or cannot restore.

I agree - I'll change this call to send it to the recycle bin instead.

EDIT: if you want to alter the translated text on that button to reflect that, I will do the same.

[vitalii2011]

It might be possible to make a list of detected/removed malicious files somewhere here: Because this: may remain undeleted (I understood your explanation of why they are not there) without tags, etc. Pests exist not only on the Internet) For example, a child can download various cool cars with nasty things and mark them all as “acceptable”.

[jtsage]

yeah, I will add what you have "permanently" ignored in there, along with a button to clear it out. I was considering having that list clear itself on the "Clear Cache" button as well

[vitalii2011]

EDIT: if you want to alter the translated text on that button to reflect that, I will do the same.

No. For what? If I get you right. )

[jtsage]

EDIT: if you want to alter the translated text on that button to reflect that, I will do the same.

No. For what? If I get you right. )

I'll probably change that button from

I do not trust it, delete it right now

to something like

I do not trust it, move it to the recycle bin it right now

[vitalii2011]

whoops. I should have checked vehicleinspector - I forget what his other massive overlay one was called …

https://www.modhoster.com/community/user/happylooser#t2

[jtsage]

oh, cool, thanks - I've not used any of his stuff in a while - but I know he spent a ton of time on library and utility functions, so they probably all use similar code to manage saved settings which is causing the false positive on this

[vitalii2011]

https://github.com/loki79uk/FS22_NoDelete/releases/tag/v0.0.0.1

[vitalii2011]

https://discord.com/channels/645566659075244043/645566659075244049

[jtsage]

https://github.com/loki79uk/FS22_NoDelete/releases/tag/v0.0.0.1

Aye, Loki and I were talking about this yesterday a bit - looks to be a useful bit of protection.

For what it's worth, this mod was actually the second entry into the global whitelist for MA's scan, as his test case there also triggers the warning :)